@julienym Highly appreciate your continuing. I just skimmed over the changes. Please add unit tests to ensure correct rendering with the new options. Some useful testing scenarios:
- Fail when…
Do you mind adding your solution to the docs? I guess there will be others having similar issues in the future.
That's a neat way. Thanks for sharing and glad you found a solution.
(Moving away from init containers will still be done at some point. Istio was not the main reason for that. 🙂)
The whole actions related app.ini
block is rendered when running helm template my-release .
, although it is disabled by default. Looks like this check is missing. And a test that covers this.
My initial comment was misleading - just realized that now. I didn't mean we should set GITEA_INSTANCE_URL
via _helpers.tpl
. This value is not known to the app.ini
. But `GITEA__SERVER__LOCAL_…
Hi. Thanks for reaching out. There are known issues with using this Helm Chart in pair with Istio. I've filed an issue to rethink the init container usage (#332). Unfortunately, none of us…
make readme
Hi everyone. First of all, thank you @dementhorr for contributing to this Chart in general, and to propose Gitea Actions in particular. 👍 I appreciate every minute you already have put into it. And @pat-s for reviewing so far.
Obsolete documentation when considering https://gitea.com/gitea/helm-chart/pulls/596/files#issuecomment-811808
Obsolete documentation when considering https://gitea.com/gitea/helm-chart/pulls/596/files#issuecomment-811808
Let's move the default value into values.yaml
. Eliminates the default usage here. 🙂
Since job.enabled: true
basically means to automatically connect the runner to Gitea, I suggest renaming the object from job
to provisioning
or autoConnect
. That makes it for users easier to understand its purpose. The fact its a Kubernetes Job is not important for users.
As mentioned for GITEA__ACTIONS__ENABLED
in https://gitea.com/gitea/helm-chart/pulls/596/files#issuecomment-811807, these preconditions should be part of the templating logic.
The current approach of only documenting what a chart user has to do manually is not ideal. Setting actions.enabled: true
should automatically configure the instance to have enable Gitea Actions. Means, it should either define gitea.config.actions.enabled
as provided inline values while templating, or inject the environment variable GITEA__ACTIONS__ENABLED=true
to the app.ini processing.
Since config
and runnerLabels
are only used within the actRunner
container, we should move those values settings into actions.statefulset.actRunner
to make that clear. It also gives a better understanding for administrators.