justusbunsi
justusbunsi commented on pull request gitea/helm-chart#559 2024-03-27 05:33:06 +00:00
Non clustered redis options

@julienym Highly appreciate your continuing. I just skimmed over the changes. Please add unit tests to ensure correct rendering with the new options. Some useful testing scenarios:

  • Fail when…
justusbunsi commented on issue gitea/helm-chart#632 2024-03-20 17:45:22 +00:00
Support for configuring Gitea from the main container

Do you mind adding your solution to the docs? I guess there will be others having similar issues in the future.

justusbunsi commented on issue gitea/helm-chart#632 2024-03-20 17:43:58 +00:00
Support for configuring Gitea from the main container

That's a neat way. Thanks for sharing and glad you found a solution.

(Moving away from init containers will still be done at some point. Istio was not the main reason for that. 🙂)

justusbunsi commented on pull request gitea/helm-chart#596 2024-03-19 17:15:53 +00:00
Add Gitea Actions act runner

The whole actions related app.ini block is rendered when running helm template my-release ., although it is disabled by default. Looks like this check is missing. And a test that covers this.

justusbunsi commented on pull request gitea/helm-chart#596 2024-03-19 17:08:33 +00:00
Add Gitea Actions act runner

My initial comment was misleading - just realized that now. I didn't mean we should set GITEA_INSTANCE_URL via _helpers.tpl. This value is not known to the app.ini. But `GITEA__SERVER__LOCAL_…

justusbunsi commented on issue gitea/helm-chart#632 2024-03-19 12:29:39 +00:00
Support for configuring Gitea from the main container

Hi. Thanks for reaching out. There are known issues with using this Helm Chart in pair with Istio. I've filed an issue to rethink the init container usage (#332). Unfortunately, none of us…

justusbunsi approved gitea/blog#356 2024-03-11 16:17:32 +00:00
Submit maintainers' review
justusbunsi commented on pull request gitea/blog#355 2024-03-11 16:08:15 +00:00
Update gitea-enterprise post date

I guess we should first sort out #356 or integrate it there.

justusbunsi created pull request gitea/helm-chart#627 2024-03-10 18:42:57 +00:00
Resolve conflicting behavior during make readme
justusbunsi pushed to readme-improvements at justusbunsi/helm-chart 2024-03-10 18:40:09 +00:00
64676c9520 Resolve conflicting behavior during `make readme`
justusbunsi created branch readme-improvements in justusbunsi/helm-chart 2024-03-10 18:40:09 +00:00
justusbunsi suggested changes for gitea/helm-chart#596 2024-03-10 18:02:27 +00:00
Add Gitea Actions act runner

Hi everyone. First of all, thank you @dementhorr for contributing to this Chart in general, and to propose Gitea Actions in particular. 👍 I appreciate every minute you already have put into it. And @pat-s for reviewing so far.

justusbunsi commented on pull request gitea/helm-chart#596 2024-03-10 18:02:27 +00:00
Add Gitea Actions act runner
justusbunsi commented on pull request gitea/helm-chart#596 2024-03-10 18:02:27 +00:00
Add Gitea Actions act runner
justusbunsi commented on pull request gitea/helm-chart#596 2024-03-10 18:02:27 +00:00
Add Gitea Actions act runner

Let's move the default value into values.yaml. Eliminates the default usage here. 🙂

justusbunsi commented on pull request gitea/helm-chart#596 2024-03-10 18:02:26 +00:00
Add Gitea Actions act runner

Is this comment a left-over from testing?

justusbunsi commented on pull request gitea/helm-chart#596 2024-03-10 18:02:26 +00:00
Add Gitea Actions act runner

Since job.enabled: true basically means to automatically connect the runner to Gitea, I suggest renaming the object from job to provisioning or autoConnect. That makes it for users easier to understand its purpose. The fact its a Kubernetes Job is not important for users.

justusbunsi commented on pull request gitea/helm-chart#596 2024-03-10 18:02:26 +00:00
Add Gitea Actions act runner

As mentioned for GITEA__ACTIONS__ENABLED in https://gitea.com/gitea/helm-chart/pulls/596/files#issuecomment-811807, these preconditions should be part of the templating logic.

justusbunsi commented on pull request gitea/helm-chart#596 2024-03-10 18:02:26 +00:00
Add Gitea Actions act runner

The current approach of only documenting what a chart user has to do manually is not ideal. Setting actions.enabled: true should automatically configure the instance to have enable Gitea Actions. Means, it should either define gitea.config.actions.enabled as provided inline values while templating, or inject the environment variable GITEA__ACTIONS__ENABLED=true to the app.ini processing.

justusbunsi commented on pull request gitea/helm-chart#596 2024-03-10 18:02:26 +00:00
Add Gitea Actions act runner

Since config and runnerLabels are only used within the actRunner container, we should move those values settings into actions.statefulset.actRunner to make that clear. It also gives a better understanding for administrators.