Show Signer in commit lists and add basic trust (#10425 & #10511) #10524

Merged
lunny merged 1 commits from backport-10511-10425 into release/v1.11 2020-02-28 17:18:03 +00:00
Contributor

Backport #10425
Backport #10511

  • Show Signer in commit lists and add basic trust (#10425)

Show the avatar of the signer in the commit list pages as we do not
enforce that the signer is an author or committer. This makes it
clearer who has signed the commit.

Also display commits signed by non-members differently from
members and in particular make it clear when a non-member signer
is different from the committer to help reduce the risk of
spoofing.

Signed-off-by: Andrew Thornton art27@cantab.net

Fix the signing icon in the view_list.tmpl page (#10511)

Co-Authored-By: silverwind me@silverwind.io
Co-authored-by: guillep2k 18600385+guillep2k@users.noreply.github.com

Backport #10425 Backport #10511 * Show Signer in commit lists and add basic trust (#10425) Show the avatar of the signer in the commit list pages as we do not enforce that the signer is an author or committer. This makes it clearer who has signed the commit. Also display commits signed by non-members differently from members and in particular make it clear when a non-member signer is different from the committer to help reduce the risk of spoofing. Signed-off-by: Andrew Thornton <art27@cantab.net> Fix the signing icon in the view_list.tmpl page (#10511) Co-Authored-By: silverwind <me@silverwind.io> Co-authored-by: guillep2k <18600385+guillep2k@users.noreply.github.com>
bagasme (Migrated from github.com) reviewed 2020-02-28 12:32:08 +00:00
@ -798,2 +798,4 @@
commits.newer = Newer
commits.signed_by = Signed by
commits.signed_by_untrusted_user = Signed by untrusted user
commits.signed_by_untrusted_user_unmatched = Signed by untrusted user who does not match committer
bagasme (Migrated from github.com) commented 2020-02-28 12:32:08 +00:00

Looks OK

Looks OK
6543 (Migrated from github.com) approved these changes 2020-02-28 15:08:46 +00:00
guillep2k (Migrated from github.com) approved these changes 2020-02-28 17:17:38 +00:00
This repo is archived. You cannot comment on pull requests.
No reviewers
No Milestone
No project
No Assignees
2 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: lunny/gitea#10524
No description provided.