Fix tab indentation in code view #10671

Merged
cipherboy merged 2 commits from fix-theme-indentation into master 2020-03-25 13:33:04 +00:00
cipherboy commented 2020-03-08 16:18:32 +00:00 (Migrated from github.com)

Resolves: #5596

Signed-off-by: Alexander Scheel <alexander.m.scheel@gmail.com>


On my system (F31, Firefox 73), this almost works. It does move the code over by one character, without having the prefixed space affect the tab indentation. The issue is that Firefox can't seem to correctly calculate the offset of the size of 8 spaces in the selected font (Liberation Mono).

See attached screenshots:

Screenshot from 2020-03-08 11-59-36

When this font is disabled, it does work:

Screenshot from 2020-03-08 11-59-47

We can probably leave the width as-is, I just updated it to keep the same original width.

Resolves: #5596 `Signed-off-by: Alexander Scheel <alexander.m.scheel@gmail.com>` ---- On my system (F31, Firefox 73), this almost works. It does move the code over by one character, without having the prefixed space affect the tab indentation. The issue is that Firefox can't seem to correctly calculate the offset of the size of 8 spaces in the selected font (Liberation Mono). See attached screenshots: ![Screenshot from 2020-03-08 11-59-36](https://user-images.githubusercontent.com/914030/76166594-08ae7280-6136-11ea-83d3-2c421e57f132.png) When this font is disabled, it does work: ![Screenshot from 2020-03-08 11-59-47](https://user-images.githubusercontent.com/914030/76166606-195ee880-6136-11ea-87cb-012af6efad9c.png) We can probably leave the width as-is, I just updated it to keep the same original width.
6543 (Migrated from github.com) approved these changes 2020-03-11 22:59:36 +00:00
6543 (Migrated from github.com) left a comment

all in all - I like the change of this pull

all in all - I like the change of this pull
mrsdizzie (Migrated from github.com) approved these changes 2020-03-25 04:13:31 +00:00
This repo is archived. You cannot comment on pull requests.
No reviewers
No Milestone
No project
No Assignees
1 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: lunny/gitea#10671
No description provided.