Add a migrate service type switch page #12697

lunny · 2020-09-03T07:11:29Z

lunny commented

2020-09-03 07:11:29 +00:00

When clicking New Migration, it will enter a new page to let users chose which Git service they want to migrate from.

Chose Git will let you migrate git data or mirror git data from any possible git services via http/https protocol or local disk if enabled.
Chose GitHub will let user migrate git/issues ... and etc. data from Github or Github Enterprise
Chose GitLab will let user migrate git/issues ... and etc. data from GitLab.com or self-hosted Gitlab

When clicking `New Migration`, it will enter a new page to let users chose which Git service they want to migrate from. - Chose Git will let you migrate git data or mirror git data from any possible git services via http/https protocol or local disk if enabled. - Chose GitHub will let user migrate git/issues ... and etc. data from Github or Github Enterprise - Chose GitLab will let user migrate git/issues ... and etc. data from GitLab.com or self-hosted Gitlab <img width="1423" alt="图片" src="https://user-images.githubusercontent.com/81045/92599461-df38f400-f2dc-11ea-8cf4-bb1c440e22b8.png"> <img width="1428" alt="图片" src="https://user-images.githubusercontent.com/81045/92599509-ed871000-f2dc-11ea-89d6-7452eb822eac.png">

👍 1 ❤️ 1

lafriks (Migrated from github.com) reviewed 2020-09-03 07:37:38 +00:00

options/locale/locale_en-US.ini

lafriks (Migrated from github.com) commented

2020-09-03 07:37:36 +00:00

It would be better to use .Name() not .Title() for translations:

migrate.github.description = Migrating data from Github.com or Github Enterprise.
migrate.git.description = Migrating or Mirroring git data from Git services
migrate.gitlab.description = Migrating data from GitLab.com or Self-Hosted repository.

It would be better to use `.Name()` not `.Title()` for translations: ```suggestion migrate.github.description = Migrating data from Github.com or Github Enterprise. migrate.git.description = Migrating or Mirroring git data from Git services migrate.gitlab.description = Migrating data from GitLab.com or Self-Hosted repository. ```

lafriks (Migrated from github.com) reviewed 2020-09-03 07:39:07 +00:00

templates/repo/migrate/migrate.tmpl

lafriks (Migrated from github.com) commented

2020-09-03 07:39:07 +00:00

								{{(Printf "repo.migrate.%s.description" .Name) | $.i18n.Tr }}

```suggestion {{(Printf "repo.migrate.%s.description" .Name) | $.i18n.Tr }} ```

lafriks (Migrated from github.com) reviewed 2020-09-03 07:39:37 +00:00

templates/repo/migrate/migrate.tmpl

lafriks (Migrated from github.com) commented

2020-09-03 07:39:36 +00:00

also for images would be better to use .Name:

							<img alt="{{.Title}}" src="{{StaticUrlPrefix}}/img/migrate/{{.Name}}.png">

also for images would be better to use `.Name`: ```suggestion <img alt="{{.Title}}" src="{{StaticUrlPrefix}}/img/migrate/{{.Name}}.png"> ```

a1012112796 (Migrated from github.com) reviewed 2020-09-09 12:17:26 +00:00

options/locale/locale_en-US.ini

						
				@ -729,11 +730,15 @@ migrate.permission_denied = You are not allowed to import local repositories.

				migrate.invalid_local_path = "The local path is invalid. It does not exist or is not a directory."

				migrate.failed = Migration failed: %v

a1012112796 (Migrated from github.com) commented

2020-09-09 12:01:02 +00:00

migrate.gitlab.description = Migrating data from GitLab.com or Self-Hosted gitlab server.

```suggestion migrate.gitlab.description = Migrating data from GitLab.com or Self-Hosted gitlab server. ```

routers/repo/migrate.go

a1012112796 (Migrated from github.com) commented

2020-09-09 12:10:51 +00:00

		Comments:       form.Issues || form.PullRequests,

In my opinon, If not migrate issues or PullRequests, comment is also not necessary.

```suggestion Comments: form.Issues || form.PullRequests, ``` In my opinon, If not migrate issues or PullRequests, comment is also not necessary.

mrsdizzie (Migrated from github.com) reviewed 2020-09-09 14:44:19 +00:00

options/locale/locale_en-US.ini

						
				@ -729,11 +730,15 @@ migrate.permission_denied = You are not allowed to import local repositories.

				migrate.invalid_local_path = "The local path is invalid. It does not exist or is not a directory."

				migrate.failed = Migration failed: %v

mrsdizzie (Migrated from github.com) commented

2020-09-09 14:44:18 +00:00

migrate.migrate_items_options = Access Token is required to migrate additional items

Since we only show these options for a service that supports them now

```suggestion migrate.migrate_items_options = Access Token is required to migrate additional items ``` Since we only show these options for a service that supports them now