Ensure user email is always in email address table #13296

2020-10-24T18:26:31Z

ivanvc commented

2020-10-24 18:26:31 +00:00

(Migrated from github.com)

This PR solves the issue with duplicated emails reported in #11251, by ensuring that the primary user email address is in the email_address table too.

Fixes #11251.

This PR solves the issue with duplicated emails reported in #11251, by ensuring that the primary user email address is in the email_address table too. Fixes #11251.

👍 3

a1012112796 (Migrated from github.com) reviewed 2020-11-01 01:55:59 +00:00

models/fixtures/user.yml

						
				@ -188,3 +188,3 @@

				  full_name: User Eleven

				  email: user11@example.com

				  email: user011@example.com

				  passwd_hash_algo: argon2

a1012112796 (Migrated from github.com) commented

2020-11-01 01:55:58 +00:00

why change ?

a1012112796 (Migrated from github.com) reviewed 2020-11-01 02:07:20 +00:00

models/migrations/v158.go

a1012112796 (Migrated from github.com) commented

2020-11-01 02:07:19 +00:00

I don't think it's necessary, because you haven't changeed the struct of them.

ivanvc (Migrated from github.com) reviewed 2020-11-03 18:12:56 +00:00

models/fixtures/user.yml

						
				@ -188,3 +188,3 @@

				  full_name: User Eleven

				  email: user11@example.com

				  email: user011@example.com

				  passwd_hash_algo: argon2

ivanvc (Migrated from github.com) commented

2020-11-03 18:12:56 +00:00

Because in the email_1ddress.yml fixtures, the user11@example.com is registered to user1, and changing that file rather than this, brings more issues and places where it should be updated (I initially went through that route with commits bdd4bc2d82 and 77cd65708e), and decided later that the minimal impact would be to update the email address here.

Because in the `email_1ddress.yml` fixtures, the `user11@example.com` is registered to `user1`, and changing that file rather than this, brings more issues and places where it should be updated (I initially went through that route with commits bdd4bc2d827fce00328493823fe3bd9e0359d73a and 77cd65708e5e56a11ae9017123a77ae35f4fe7fb), and decided later that the minimal impact would be to update the email address here.