lunny/gitea

Archived

Format files #13698

Merged

6543 merged 12 commits from format-files into master

2020-11-28 06:12:23 +00:00

6543 commented

2020-11-25 00:07:03 +00:00

(Migrated from github.com)

as title ...

It's anoing to see many lines of diff if you edit one of this files and the editor automaticaly correct unrelated things.

this pull format files so there will be less + fix alignment of "make help"

this pull does not change any behaviour

as title ... It's anoing to see many lines of diff if you edit one of this files and the editor automaticaly correct unrelated things. this pull format files so there will be less + fix alignment of "make help" **this pull does not change any behaviour**

silverwind (Migrated from github.com) reviewed 2020-11-25 00:28:11 +00:00

docs/.editorconfig

silverwind (Migrated from github.com) commented

2020-11-25 00:28:11 +00:00

May want to merge this file with the one in root (and update any files in docs to conform).

May want to merge this file with the one in root (and update any files in `docs` to conform).

silverwind (Migrated from github.com) reviewed 2020-11-25 00:32:08 +00:00

.eslintrc

silverwind (Migrated from github.com) commented

2020-11-25 00:32:08 +00:00

I don't particularily like this style of spacing and we don't do it in JS either. Maybe rename to .eslintrc.yaml to see if that shuts up your tool?

I don't particularily like this style of spacing and we don't do it in JS either. Maybe rename to `.eslintrc.yaml` to see if that shuts up your tool?

silverwind (Migrated from github.com) reviewed 2020-11-25 00:32:45 +00:00

build/generate-svg.js

silverwind (Migrated from github.com) commented

2020-11-25 00:32:45 +00:00

Is it really an issue? eslint certainly doesn't complain about it.

Is it really an issue? eslint certainly doesn't complain about it.

6543 (Migrated from github.com) reviewed 2020-11-25 00:33:27 +00:00

build/generate-svg.js

6543 (Migrated from github.com) commented

2020-11-25 00:33:27 +00:00

it's not - the importand thing for me was about markdown and ini files :)

it's not - the importand thing for me was about markdown and ini files :)

6543 (Migrated from github.com) reviewed 2020-11-25 00:41:18 +00:00

.eslintrc

6543 (Migrated from github.com) commented

2020-11-25 00:41:18 +00:00

@silverwind is .eslintrc.yaml supported by our js linter?

@silverwind is `.eslintrc.yaml` supported by our js linter?

6543 (Migrated from github.com) reviewed 2020-11-25 00:42:04 +00:00

.eslintrc

6543 (Migrated from github.com) commented

2020-11-25 00:42:04 +00:00

never mind ... it does not work anyway ... - reverting

never mind ... it does not work anyway ... - reverting

6543 (Migrated from github.com) reviewed 2020-11-25 00:51:20 +00:00

docs/.editorconfig

6543 (Migrated from github.com) commented

2020-11-25 00:51:20 +00:00

@silverwind done

@silverwind done

lafriks (Migrated from github.com) reviewed 2020-11-25 04:59:34 +00:00

.editorconfig

lafriks (Migrated from github.com) commented

2020-11-25 04:59:34 +00:00

Ident size 8 imho is way too much ?

Ident size 8 imho is way too much ?

lafriks (Migrated from github.com) reviewed 2020-11-25 05:00:44 +00:00

.editorconfig

lafriks (Migrated from github.com) commented

2020-11-25 05:00:44 +00:00

For javascript most defaults to 2 spaces identing

For javascript most defaults to 2 spaces identing

silverwind (Migrated from github.com) reviewed 2020-11-25 07:52:56 +00:00

.eslintrc

silverwind (Migrated from github.com) commented

2020-11-25 07:52:56 +00:00

.eslintrc.yaml should generally work except for maybe some outdated editor integrations which is the reason I generally use the older .eslintrc.

`.eslintrc.yaml` should generally work except for maybe some outdated editor integrations which is the reason I generally use the older `.eslintrc`.

silverwind (Migrated from github.com) reviewed 2020-11-25 07:54:15 +00:00

.editorconfig

silverwind (Migrated from github.com) commented

2020-11-25 07:54:15 +00:00

That section can just be removed, we use size 2 for go since a while now inherited from [*].

That section can just be removed, we use size 2 for go since a while now inherited from `[*]`.

silverwind (Migrated from github.com) reviewed 2020-11-25 07:55:38 +00:00

.editorconfig

silverwind (Migrated from github.com) commented

2020-11-25 07:55:38 +00:00

I'd remove this as well and reindent matching files in docs. The other formats should already be at 2-space outside that folder.

I'd remove this as well and reindent matching files in `docs`. The other formats should already be at 2-space outside that folder.

silverwind (Migrated from github.com) reviewed 2020-11-25 07:56:11 +00:00

.editorconfig

silverwind (Migrated from github.com) commented

2020-11-25 07:56:10 +00:00

Remove as well, I remember specifically removing this advertisment ?

Remove as well, I remember specifically removing this advertisment ?

silverwind (Migrated from github.com) approved these changes 2020-11-25 22:38:02 +00:00

lafriks (Migrated from github.com) approved these changes 2020-11-26 13:03:46 +00:00

zeripath approved these changes 2020-11-27 20:17:54 +00:00

This repo is archived. You cannot comment on pull requests.

No reviewers

No Label

good first issue

hacktoberfest-accepted

kind/deployment

kind/deprecated

kind/enhancement

kind/moderation

kind/regression

kind/translation

kind/upstream-related

performance/bigrepo

performance/cpu

performance/memory

performance/speed

priority/critical

priority/medium

proposal/rejected

reviewed/confirmed

reviewed/duplicate

reviewed/invalid

reviewed/not-a-bug

reviewed/wontfix

status/needs-feedback

theme/authentication

theme/backup-restore

theme/federation

theme/migration

theme/timetracker

No Milestone

No project

No Assignees

2 Participants

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: lunny/gitea#13698

No description provided.