lunny/gitea

Archived

Add code block highlight to orgmode back #14222

Merged

lunny merged 10 commits from lunny/fix_orgmod_highlight into main

2021-06-23 20:45:47 +00:00

lunny commented

2021-01-03 10:28:20 +00:00

Owner

Partially fix #14219. After #12047 merged, all code block highlight from frontend to backend. All markdown files has been handled well but orgmode and third-party renderer lost code block highlight .

This PR takes orgmode code block highlight back.

Partially fix #14219. After #12047 merged, all code block highlight from frontend to backend. All markdown files has been handled well but orgmode and third-party renderer lost code block highlight . This PR takes orgmode code block highlight back.

silverwind (Migrated from github.com) reviewed 2021-01-03 14:07:11 +00:00

modules/markup/orgmode/orgmode.go

silverwind (Migrated from github.com) commented

2021-01-03 14:07:11 +00:00

Author

Owner

Most of this is duplicating with modules/markup/markdown/markdown.go, can we extract it to a shared function like RenderCodePre?

Most of this is duplicating with `modules/markup/markdown/markdown.go`, can we extract it to a shared function like `RenderCodePre`?

lunny reviewed 2021-01-03 15:10:22 +00:00

modules/markup/orgmode/orgmode.go

lunny commented

2021-01-03 15:10:22 +00:00

Author

Owner

I think they are similar but different functions. markdown's will be invoked twice, once before rendering the code, another after rendering the code. But orgmode is only one function.
Is it really valuable to merge the two functions since Gitea only supports the two formats.

I think they are similar but different functions. `markdown`'s will be invoked twice, once before rendering the code, another after rendering the code. But orgmode is only one function. Is it really valuable to merge the two functions since Gitea only supports the two formats.

zeripath reviewed 2021-01-03 16:25:02 +00:00

modules/markup/orgmode/orgmode.go

zeripath commented

2021-01-03 16:25:02 +00:00

Contributor

I think this looks sufficiently different from the code in markdown.go

I think this looks sufficiently different from the code in `markdown.go`

zeripath approved these changes 2021-01-03 16:25:29 +00:00

6543 (Migrated from github.com) requested changes 2021-01-23 18:44:36 +00:00

6543 (Migrated from github.com) left a comment

Author

Owner

TESTED: this will destroy orgmode render

(against https://try.gitea.io/mrsdizzie/github-orgmode-tests)

TESTED: this will destroy orgmode render (against https://try.gitea.io/mrsdizzie/github-orgmode-tests)

lafriks (Migrated from github.com) approved these changes 2021-01-23 19:36:39 +00:00

6543 (Migrated from github.com) approved these changes 2021-06-23 19:51:08 +00:00

This repo is archived. You cannot comment on pull requests.

No reviewers

No Label

good first issue

hacktoberfest-accepted

kind/deployment

kind/deprecated

kind/enhancement

kind/moderation

kind/regression

kind/translation

kind/upstream-related

performance/bigrepo

performance/cpu

performance/memory

performance/speed

priority/critical

priority/medium

proposal/rejected

reviewed/confirmed

reviewed/duplicate

reviewed/invalid

reviewed/not-a-bug

reviewed/wontfix

status/needs-feedback

theme/authentication

theme/backup-restore

theme/federation

theme/migration

theme/timetracker

No Milestone

No project

No Assignees

2 Participants

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: lunny/gitea#14222

No description provided.