Introduce esbuild on webpack #14578

lunny · 2021-02-05T13:20:38Z

lunny commented

2021-02-05 13:20:38 +00:00

make the frontend build faster and use less memory. It's about 2x faster than before on my macOS.

❤️ 5

silverwind (Migrated from github.com) reviewed 2021-02-05 14:39:39 +00:00

webpack.config.js

silverwind (Migrated from github.com) commented

2021-02-05 14:39:39 +00:00

const {ESBuildPlugin, ESBuildMinifyPlugin} = require('esbuild-loader');

```suggestion const {ESBuildPlugin, ESBuildMinifyPlugin} = require('esbuild-loader'); ```

silverwind (Migrated from github.com) reviewed 2021-02-05 14:40:34 +00:00

webpack.config.js

silverwind (Migrated from github.com) commented

2021-02-05 14:40:34 +00:00

```suggestion ```

6543 (Migrated from github.com) reviewed 2021-03-21 08:34:28 +00:00

webpack.config.js

6543 (Migrated from github.com) commented

2021-03-21 08:34:27 +00:00

        target: 'es2015',

(there are no options below to see)

```suggestion target: 'es2015', ``` (there are no options below to see)

6543 (Migrated from github.com) reviewed 2021-03-21 10:25:27 +00:00

Makefile

6543 (Migrated from github.com) commented

2021-03-21 10:25:27 +00:00

wee need node_modules to be able building and/or package things without internet for some distros!

wee need **node_modules** to be able building and/or package things without internet for some distros!

CL-Jeremy (Migrated from github.com) reviewed 2021-03-21 10:27:58 +00:00

Makefile

CL-Jeremy (Migrated from github.com) commented

2021-03-21 10:27:57 +00:00

Nope, this is done with .npm-cache now. See lunny#12 for that. npm install is now working without any Internet connection (see my screenshots above, WiFi is off the whole time, and things builds perfectly on Windows, even Fomantic UI).

Nope, this is done with .npm-cache now. See lunny#12 for that. `npm install` is now working without any Internet connection (see my screenshots above, WiFi is off the whole time, and things builds perfectly on Windows, even Fomantic UI).

zeripath approved these changes 2021-03-27 12:22:27 +00:00

silverwind (Migrated from github.com) reviewed 2021-03-29 21:17:25 +00:00

Makefile

silverwind (Migrated from github.com) commented

2021-03-29 21:17:25 +00:00

I think these fsevents can be dropped, they are generally considered optional dependencies, so nothing should break if they are not there.

I think these `fsevents` can be dropped, they are generally considered optional dependencies, so nothing should break if they are not there.

silverwind (Migrated from github.com) reviewed 2021-03-29 21:23:06 +00:00

webpack.config.js

silverwind (Migrated from github.com) commented

2021-03-29 21:23:06 +00:00

              target: 'es2015'

```suggestion target: 'es2015' ```

silverwind (Migrated from github.com) reviewed 2021-03-29 21:34:40 +00:00

webpack.config.js

silverwind (Migrated from github.com) commented

2021-03-29 21:34:40 +00:00

^

(This comment was copied from the module README, should not be there)

^ (This comment was copied from the module README, should not be there)

silverwind (Migrated from github.com) reviewed 2021-03-29 21:37:22 +00:00

Makefile

silverwind (Migrated from github.com) commented

2021-03-29 21:37:22 +00:00

Actually, I wonder where they are required in first place. I know some webpack 4 modules did need them as a optional dependency to chokidar but if I run a npm ls fsevents or npm ls chokidar on a Mac on master, I get an empty result. So maybe they are already obsolete?

Actually, I wonder where they are required in first place. I know some webpack 4 modules did need them as a optional dependency to `chokidar` but if I run a `npm ls fsevents` or `npm ls chokidar` on a Mac on master, I get an empty result. So maybe they are already obsolete?

silverwind (Migrated from github.com) reviewed 2021-03-29 21:39:57 +00:00

Makefile

						
				@ -672,14 +695,22 @@ npm-update: node-check | node_modules

				.PHONY: fomantic

silverwind (Migrated from github.com) commented

2021-03-29 21:39:56 +00:00

Is this less@3 needed because main project uses less@4? Shouldn't that be a non-issue because fomantic has its own node_modules and depends on less?

Is this `less@3` needed because main project uses `less@4`? Shouldn't that be a non-issue because fomantic has its own `node_modules` and depends on `less`?

CL-Jeremy (Migrated from github.com) reviewed 2021-03-29 22:58:58 +00:00

Makefile

						
				@ -672,14 +695,22 @@ npm-update: node-check | node_modules

				.PHONY: fomantic

CL-Jeremy (Migrated from github.com) commented

2021-03-29 22:58:58 +00:00

At least it won't work when less@4 is installed. I agree specifying less@3 explicitly with fomantic-ui is unnecessary.

At least it won't work when `less@4` is installed. I agree specifying `less@3` explicitly with `fomantic-ui` is unnecessary.

CL-Jeremy (Migrated from github.com) reviewed 2021-03-30 00:14:31 +00:00

Makefile

CL-Jeremy (Migrated from github.com) commented

2021-03-30 00:14:31 +00:00

Okay those are actually for gulp, which requires chokidar@2 and fsevents@1. fsevents@2 isn't needed by anything as of now. My bad. PR is on the way.

Okay those are actually for `gulp`, which requires `chokidar@2` and `fsevents@1`. `fsevents@2` isn't needed by anything as of now. My bad. PR is on the way.