Create Proper Migration tests #15116

zeripath · 2021-03-22T21:34:19Z

zeripath commented

2021-03-22 21:34:19 +00:00

Unfortunately our testing regime has so far meant that migrations do not
get proper testing.

This PR begins the process of creating migration tests for this.

Signed-off-by: Andrew Thornton art27@cantab.net

Unfortunately our testing regime has so far meant that migrations do not get proper testing. This PR begins the process of creating migration tests for this. Signed-off-by: Andrew Thornton <art27@cantab.net>

❤️ 5

zeripath reviewed 2021-03-22 22:00:00 +00:00

models/migrations/v177_test.go

zeripath commented

2021-03-22 22:00:00 +00:00

```suggestion ```

zeripath reviewed 2021-03-22 22:04:01 +00:00

models/migrations/migrations_test.go

zeripath commented

2021-03-22 22:00:43 +00:00

```suggestion ```

zeripath commented

2021-03-22 22:03:52 +00:00

		t.Logf("no fixtures found in: %s", fixturesDir)

```suggestion t.Logf("no fixtures found in: %s", fixturesDir) ```

models/migrations/migrations_test.go

						
				@ -0,0 +195,4 @@

				// Provide models to be sync'd with the database - in particular any models you expect fixtures to be loaded from.

				//

				// fixtures in `models/migrations/fixtures/<TestName>` will be loaded automatically

				func prepareTestEnv(t *testing.T, skip int, syncModels ...interface{}) (*xorm.Engine, func()) {

zeripath commented

2021-03-22 22:02:34 +00:00

// prepareTestEnv prepares the test environment. The skip parameter should usually be 0. Provide models to be sync'd
// with the database - in particular any models you expect fixtures to be loaded from.
//
// fixtures in `models/migrations/fixtures/<TestName>` will be loaded automatically
func prepareTestEnv(t *testing.T, skip int, syncModels ...interface{}) (*xorm.Engine, func()) {

```suggestion // prepareTestEnv prepares the test environment. The skip parameter should usually be 0. Provide models to be sync'd // with the database - in particular any models you expect fixtures to be loaded from. // // fixtures in `models/migrations/fixtures/<TestName>` will be loaded automatically func prepareTestEnv(t *testing.T, skip int, syncModels ...interface{}) (*xorm.Engine, func()) { ```

6543 (Migrated from github.com) approved these changes 2021-03-23 12:19:58 +00:00

kdumontnu (Migrated from github.com) approved these changes 2021-03-24 16:00:39 +00:00

kdumontnu (Migrated from github.com) left a comment

Thanks for adding these! ?

Do you think it would be good practice to add a comment block at the top of v176_test.go and v177_test.go to explain at high level what the migrations intend to do? Ex. "create index X", etc.

Thanks for adding these! ? Do you think it would be good practice to add a comment block at the top of `v176_test.go` and `v177_test.go` to explain at high level what the migrations intend to do? Ex. "create index X", etc.

6543 (Migrated from github.com) approved these changes 2021-03-24 18:26:14 +00:00

This repo is archived. You cannot comment on pull requests.

No reviewers

kdumontnu

6543