lunny/gitea
Archived
1
1
Fork 1
Code Issues 1.7k Pull Requests 154 Projects Releases 128 Wiki Activity

Let package git depend on setting but not opposite #15241

Merged
lunny merged 8 commits from lunny/refactor_git into main 2021-06-26 11:28:55 +00:00
Conversation 0 Commits 8 Files Changed 17 +113 -92
lunny commented 2021-04-01 15:51:57 +00:00
Owner
Copy Link

Package Setting should be dependent by package git but not opposite.

Extract from #15234 .

Package `Setting` should be dependent by package `git` but not opposite. Extract from #15234 .
6543 (Migrated from github.com) reviewed 2021-04-01 16:08:56 +00:00
modules/git/repo.go
6543 (Migrated from github.com) commented 2021-04-01 16:08:56 +00:00
Author
Owner

i thin there was a dummy reader for this ...

Can we make this field optional and check in RunWithContext if nil set dummy reader?

i thin there was a dummy reader for this ... Can we make this field optional and check in RunWithContext if nil set dummy reader?
lunny reviewed 2021-04-02 06:50:51 +00:00
modules/git/repo.go
lunny commented 2021-04-02 06:50:51 +00:00
Author
Owner

I have removed this changes from this PR.

I have removed this changes from this PR.
6543 (Migrated from github.com) approved these changes 2021-04-12 12:42:10 +00:00
6543 (Migrated from github.com) reviewed 2021-04-12 15:40:11 +00:00
modules/avatar/avatar.go
6543 (Migrated from github.com) commented 2021-04-12 15:40:10 +00:00
Author
Owner

unrelated fix/enhancement !?!?

unrelated fix/enhancement !?!?
lunny reviewed 2021-04-12 15:56:34 +00:00
modules/avatar/avatar.go
lunny commented 2021-04-12 15:56:34 +00:00
Author
Owner

No. It's related. Once setting don't depend on git, no image/jpeg imported to avatar and then read jpeg file will fail. I guess because git has already imported the package.

No. It's related. Once `setting` don't depend on `git`, no `image/jpeg` imported to avatar and then read jpeg file will fail. I guess because `git` has already imported the package.
KN4CK3R (Migrated from github.com) reviewed 2021-04-12 16:45:12 +00:00
modules/avatar/avatar.go
KN4CK3R (Migrated from github.com) commented 2021-04-12 16:45:12 +00:00
Author
Owner

I have something similiar here

I have something similiar [here](https://github.com/go-gitea/gitea/pull/14867/commits/d300009041c1c87d9331217d9fa34c9fa015ef0d)
techknowlogick approved these changes 2021-06-26 03:57:30 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
techknowlogick
6543
Labels
Clear labels   
backport/done

   
backport/v1.0

   
backport/v1.1

   
backport/v1.10

   
backport/v1.11

   
backport/v1.12

   
backport/v1.13

   
backport/v1.14

   
backport/v1.15

   
backport/v1.2

   
backport/v1.3

   
backport/v1.4

   
backport/v1.5

   
backport/v1.6

   
backport/v1.7

   
backport/v1.8

   
backport/v1.9

   
bounty

   
changelog

   
dependencies

Pull requests that update a dependency file

  
frontport/done

   
frontport/main

   
good first issue

Likely to be an easy fix

  
Hacktoberfest

   
hacktoberfest-accepted

   
in progress

   
kind/api

   
kind/breaking

   
kind/bug

   
kind/build

   
kind/deployment

   
kind/deprecated

   
kind/docs

   
kind/enhancement

   
kind/feature

   
kind/lint

   
kind/misc

   
kind/moderation

features for moderateing spam, abuse, ...

  
kind/package

   
kind/proposal

   
kind/question

   
kind/refactor

   
kind/regression

   
kind/security

   
kind/summary

   
kind/testing

   
kind/translation

   
kind/ui

   
kind/upstream-related

An issue that is caused by an upstream dependency

  
kind/usability

   
kind/ux

   
lgtm/done

   
lgtm/need 1

   
lgtm/need 2

   
performance/bigrepo

Performance Issues affecting Big Repositories

  
performance/cpu

   
performance/memory

Performance issues affecting memory use

  
performance/speed

performance issues with slow downs

  
priority/critical

   
priority/low

   
priority/maybe

   
priority/medium

   
proposal/rejected

   
reviewed/confirmed

Issue has been reviewed and confirmed to be present or accepted to be implemented

  
reviewed/duplicate

   
reviewed/fixed

A fix for this issue is already in the attached milestone

  
reviewed/invalid

   
reviewed/not-a-bug

The reported issue is the intended behavior

  
reviewed/wontfix

   
skip-changelog

   
stale

   
status/blocked

   
status/needs-feedback

   
status/wip

   
theme/2fa

   
theme/authentication

   
theme/avatar

   
theme/backup-restore

   
theme/docker

Docker themed issued

  
theme/federation

   
theme/issues

   
theme/kanban

   
theme/markdown

   
theme/migration

Migration issues

  
theme/mobile

   
theme/pr

   
theme/signing

   
theme/sqlite

   
theme/timetracker

   
theme/webhook

   
theme/wiki
No Label
backport/done
backport/v1.0
backport/v1.1
backport/v1.10
backport/v1.11
backport/v1.12
backport/v1.13
backport/v1.14
backport/v1.15
backport/v1.2
backport/v1.3
backport/v1.4
backport/v1.5
backport/v1.6
backport/v1.7
backport/v1.8
backport/v1.9
bounty
changelog
dependencies
frontport/done
frontport/main
good first issue
Hacktoberfest
hacktoberfest-accepted
in progress
kind/api
kind/breaking
kind/bug
kind/build
kind/deployment
kind/deprecated
kind/docs
kind/enhancement
kind/feature
kind/lint
kind/misc
kind/moderation
kind/package
kind/proposal
kind/question
kind/refactor
kind/regression
kind/security
kind/summary
kind/testing
kind/translation
kind/ui
kind/upstream-related
kind/usability
kind/ux
lgtm/done
lgtm/need 1
lgtm/need 2
performance/bigrepo
performance/cpu
performance/memory
performance/speed
priority/critical
priority/low
priority/maybe
priority/medium
proposal/rejected
reviewed/confirmed
reviewed/duplicate
reviewed/fixed
reviewed/invalid
reviewed/not-a-bug
reviewed/wontfix
skip-changelog
stale
status/blocked
status/needs-feedback
status/wip
theme/2fa
theme/authentication
theme/avatar
theme/backup-restore
theme/docker
theme/federation
theme/issues
theme/kanban
theme/markdown
theme/migration
theme/mobile
theme/pr
theme/signing
theme/sqlite
theme/timetracker
theme/webhook
theme/wiki
Milestone
Clear milestone
No items
No Milestone
1.15.0
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: lunny/gitea#15241
No description provided.
Delete Branch "lunny/refactor_git"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?