lunny/gitea

Archived

Create a session on ReverseProxy and ensure that ReverseProxy users cannot change username #15304

Merged

lunny merged 12 commits from reverse-proxy-should-create-session into main

2021-05-15 18:33:13 +00:00

zeripath commented

2021-04-06 10:00:08 +00:00

Contributor

ReverseProxy users should generate a session on reverse proxy username change.

Also prevent ReverseProxy users from changing their username.

Extract #15816

Signed-off-by: Andrew Thornton art27@cantab.net

ReverseProxy users should generate a session on reverse proxy username change. Also prevent ReverseProxy users from changing their username. Fix #2407 Extract #15816 Signed-off-by: Andrew Thornton <art27@cantab.net>

silverwind (Migrated from github.com) reviewed 2021-04-06 18:29:47 +00:00

modules/auth/sso/reverseproxy.go

silverwind (Migrated from github.com) commented

2021-04-06 18:29:47 +00:00

Which PWA resources are you referring to? I thought we eliminated all of them (previously templates/pwa).

Which PWA resources are you referring to? I thought we eliminated all of them (previously `templates/pwa`).

zeripath reviewed 2021-04-06 19:37:47 +00:00

modules/auth/sso/reverseproxy.go

zeripath commented

2021-04-06 19:37:46 +00:00

Author

Contributor

I just copied this from the comment on the sspi_windows file.

I just copied this from the comment on the sspi_windows file.

zeripath reviewed 2021-04-06 19:45:05 +00:00

modules/auth/sso/reverseproxy.go

zeripath commented

2021-04-06 19:45:04 +00:00

Author

Contributor

	// Make sure requests to API paths, attachment downloads, git and LFS do not create a new session

```suggestion // Make sure requests to API paths, attachment downloads, git and LFS do not create a new session ```

lunny reviewed 2021-04-11 03:48:14 +00:00

modules/auth/sso/reverseproxy.go

lunny commented

2021-04-11 03:48:13 +00:00

!r.isAutoRegisterAllowed() ?

`!r.isAutoRegisterAllowed()` ?

zeripath reviewed 2021-04-11 11:40:07 +00:00

modules/auth/sso/reverseproxy.go

zeripath commented

2021-04-11 11:40:07 +00:00

Author

Contributor

		if !models.IsErrUserNotExist(err) || !r.isAutoRegisterAllowed() {

```suggestion if !models.IsErrUserNotExist(err) || !r.isAutoRegisterAllowed() { ```

techknowlogick approved these changes 2021-05-01 23:55:45 +00:00

silverwind (Migrated from github.com) reviewed 2021-05-04 16:29:14 +00:00

modules/auth/sso/sso.go

silverwind (Migrated from github.com) commented

2021-05-04 16:29:14 +00:00

Maybe add some tests for this function?

Maybe add some tests for this function?

6543 (Migrated from github.com) approved these changes 2021-05-15 17:57:24 +00:00

This repo is archived. You cannot comment on pull requests.

No reviewers

No Label

good first issue

hacktoberfest-accepted

kind/deployment

kind/deprecated

kind/enhancement

kind/moderation

kind/regression

kind/translation

kind/upstream-related

performance/bigrepo

performance/cpu

performance/memory

performance/speed

priority/critical

priority/medium

proposal/rejected

reviewed/confirmed

reviewed/duplicate

reviewed/invalid

reviewed/not-a-bug

reviewed/wontfix

status/needs-feedback

theme/authentication

theme/backup-restore

theme/federation

theme/migration

theme/timetracker

No Milestone

No project

No Assignees

3 Participants

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: lunny/gitea#15304

No description provided.