WIP: Replace easymde with textarea #15394

delvh · 2021-04-10T20:04:08Z

silverwind commented

2021-04-10 20:04:08 +00:00

(Migrated from github.com)

WIP on the easymde replacement. Basically it rips out EasyMDE without much second thought. Issue commenting works but other things may be broken.

TODOs:

Fix up loose ends, quote reply, image paste, etc
Replace Tribute with something better, remove RequireTribute
Finish style removal, remove _editor.less
Add toolbar when editing markdown files in the repo
Fix review textarea
Re-Implement fullscreen side-by-side (maybe for another PR)

Fixes https://github.com/go-gitea/gitea/issues/10729 and a probably 30 other issues.

WIP on the easymde replacement. Basically it rips out EasyMDE without much second thought. Issue commenting works but other things may be broken. TODOs: - [ ] Fix up loose ends, quote reply, image paste, etc - [ ] Replace Tribute with something better, remove `RequireTribute` - [ ] Finish style removal, remove _editor.less - [ ] Add toolbar when editing markdown files in the repo - [ ] Fix review textarea - [ ] Re-Implement fullscreen side-by-side (maybe for another PR) Fixes https://github.com/go-gitea/gitea/issues/10729 and a probably 30 other issues. <img width="748" alt="image" src="https://user-images.githubusercontent.com/115237/114283072-31472100-9a48-11eb-8bca-a8fb2001e7f9.png">

👍 7

delvh reviewed 2021-10-16 22:50:03 +00:00

web_src/js/features/markdowneditor.js

						
				@ -0,0 +74,4 @@

				function initCtrlEnterSubmit(el) {

				  el.addEventListener('keydown', (e) => {

				    if (((e.ctrlKey && !e.altKey) || e.metaKey) && (e.keyCode === 13 || e.keyCode === 10)) {

delvh commented

2021-10-16 22:47:43 +00:00

What is keycode 10? I think 13 is Enter, but what is 10?

web_src/js/index.js

delvh commented

2021-10-16 22:11:35 +00:00

Nice merge conflict! 😆

Nice merge conflict! :laughing:

web_src/js/index.js

delvh commented

2021-10-16 22:16:57 +00:00

Why explicitly not a review textarea?
Because there would be some confusion as to what a "Ctrl+Submit" should do there?

Why explicitly not a review textarea? Because there would be some confusion as to what a "Ctrl+Submit" should do there?

web_src/js/index.js

delvh commented

2021-10-16 22:41:38 +00:00

I have tried to come up with a suggestion on my own but failed due to missing jquery knowledge, so here in plain text for you to figure out:
Don't use only the first element. Use all of the available textareas. That way you can ensure that one exists as well as that all are converted to a markdown editor.

I have tried to come up with a suggestion on my own but failed due to missing jquery knowledge, so here in plain text for you to figure out: Don't use only the first element. Use all of the available textareas. That way you can ensure that one exists as well as that all are converted to a markdown editor.

web_src/js/index.js

						
				@ -1253,4 +1166,3 @@

				      autoSimpleMDE.codemirror.refresh();

				      $(this).parent().hide();

				    });

				  }

delvh commented

2021-10-16 22:43:12 +00:00

See above.

web_src/js/index.js

delvh commented

2021-10-16 22:43:28 +00:00

And again.

web_src/js/index.js

delvh commented

2021-10-16 22:44:46 +00:00

This one is tricky, however. Ideas?

web_src/js/index.js

delvh commented

2021-10-16 22:44:15 +00:00

I would not assume that we will always have only one textarea.

wxiaoguang reviewed 2021-10-17 04:33:17 +00:00

web_src/js/features/markdowneditor.js

						
				@ -0,0 +74,4 @@

				function initCtrlEnterSubmit(el) {

				  el.addEventListener('keydown', (e) => {

				    if (((e.ctrlKey && !e.altKey) || e.metaKey) && (e.keyCode === 13 || e.keyCode === 10)) {