lunny/gitea

Archived

Fix NPE on view commit with notes #15561

Merged

lunny merged 2 commits from fix-15558-notes-path into master

2021-04-21 18:00:27 +00:00

zeripath commented

2021-04-20 20:43:07 +00:00

Contributor

There is a mistake with the native git variant of GetNote when the note is referring to a non-root path.

This PR simply splits the path and passes the basedir into GetLastCommitPaths separate from the root path.

Signed-off-by: Andrew Thornton art27@cantab.net

There is a mistake with the native git variant of GetNote when the note is referring to a non-root path. This PR simply splits the path and passes the basedir into GetLastCommitPaths separate from the root path. Fix #15558 Signed-off-by: Andrew Thornton <art27@cantab.net>

lunny approved these changes 2021-04-21 08:48:08 +00:00

6543 (Migrated from github.com) approved these changes 2021-04-21 16:36:43 +00:00

This repo is archived. You cannot comment on pull requests.

No reviewers

No Label

good first issue

hacktoberfest-accepted

kind/deployment

kind/deprecated

kind/enhancement

kind/moderation

kind/regression

kind/translation

kind/upstream-related

performance/bigrepo

performance/cpu

performance/memory

performance/speed

priority/critical

priority/medium

proposal/rejected

reviewed/confirmed

reviewed/duplicate

reviewed/invalid

reviewed/not-a-bug

reviewed/wontfix

status/needs-feedback

theme/authentication

theme/backup-restore

theme/federation

theme/migration

theme/timetracker

No Milestone

No project

No Assignees

2 Participants

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: lunny/gitea#15561

No description provided.