Return go-get info on subdirs #15642

zeripath · 2021-04-27T19:41:13Z

zeripath commented

2021-04-27 19:41:13 +00:00

This PR is an alternative to #15628 and makes the go get handler a
handler.

Fix #15625

Close #15628

Signed-off-by: Andrew Thornton art27@cantab.net

This PR is an alternative to #15628 and makes the go get handler a handler. Fix #15625 Close #15628 Signed-off-by: Andrew Thornton <art27@cantab.net>

jolheiser reviewed 2021-04-27 20:17:15 +00:00

routers/routes/goget.go

						
				@ -0,0 +14,4 @@

					"code.gitea.io/gitea/modules/context"

					"code.gitea.io/gitea/modules/setting"

					"code.gitea.io/gitea/modules/util"

					"github.com/unknwon/com"

jolheiser commented

2021-04-27 20:17:15 +00:00

Just because you're already fiddling here, maybe we could replace com.Expand with os.Expand? ?

Just because you're already fiddling here, maybe we could replace `com.Expand` with `os.Expand`? ?

jolheiser reviewed 2021-04-27 20:22:03 +00:00

routers/routes/goget.go

						
				@ -0,0 +18,4 @@

				)

				func goGet(ctx *context.Context) {

					if ctx.Req.Method != "GET" || ctx.Query("go-get") != "1" || len(ctx.Req.URL.Query()) > 1 {

jolheiser commented

2021-04-27 20:20:57 +00:00

Wouldn't len(ctx.Req.URL.Query()) > 1 always be true for ?go-get=1

Wouldn't `len(ctx.Req.URL.Query()) > 1` always be true for `?go-get=1`

zeripath reviewed 2021-04-27 20:24:18 +00:00

routers/routes/goget.go

						
				@ -0,0 +18,4 @@

				)

				func goGet(ctx *context.Context) {

					if ctx.Req.Method != "GET" || ctx.Query("go-get") != "1" || len(ctx.Req.URL.Query()) > 1 {

zeripath commented

2021-04-27 20:24:17 +00:00

> 1 not > 0 ... this is so that it only fires if there is only 1 query param - go-get=1

`> 1` not `> 0` ... this is so that it only fires if there is only 1 query param - go-get=1

jolheiser reviewed 2021-04-27 20:25:54 +00:00

routers/routes/goget.go

						
				@ -0,0 +18,4 @@

				)

				func goGet(ctx *context.Context) {

					if ctx.Req.Method != "GET" || ctx.Query("go-get") != "1" || len(ctx.Req.URL.Query()) > 1 {

jolheiser commented

2021-04-27 20:25:54 +00:00

Aha, sorry I was thinking it returned the query-string. I see it returns url.Values.

Aha, sorry I was thinking it returned the query-string. I see it returns `url.Values`.

zeripath reviewed 2021-04-27 20:29:15 +00:00

routers/routes/goget.go

						
				@ -0,0 +14,4 @@

					"code.gitea.io/gitea/modules/context"

					"code.gitea.io/gitea/modules/setting"

					"code.gitea.io/gitea/modules/util"

					"github.com/unknwon/com"

zeripath commented

2021-04-27 20:29:14 +00:00

it's doing something different from os.Expand.

It might be better to actually change this to use a go-template instead.

it's doing something different from os.Expand. It might be better to actually change this to use a go-template instead.

jolheiser reviewed 2021-04-27 20:30:04 +00:00

routers/routes/goget.go

						
				@ -0,0 +14,4 @@

					"code.gitea.io/gitea/modules/context"

					"code.gitea.io/gitea/modules/setting"

					"code.gitea.io/gitea/modules/util"

					"github.com/unknwon/com"