Add email headers #15939

Merged
KN4CK3R merged 3 commits from feature-email-header into main 2021-05-22 06:47:17 +00:00
KN4CK3R commented 2021-05-21 11:24:32 +00:00 (Migrated from github.com)

fixes #15926
related #13585, #10808, #13283

Added some custom headers to issue emails to support better filters. See #15926 for details.

Like in webhooks I have added X-GitHub- and X-GitLab- headers too but want your opinion if we want to send them or not. The ...-Reason header may not match what they are sending.

Part of a test mail (sorted):

In-Reply-To: <KN4CK3R/TestRepo/issues/1@localhost>
List-Archive: <http://localhost:3000/KN4CK3R/TestRepo>
List-ID: KN4CK3R/TestRepo <TestRepo.KN4CK3R.localhost>
References: <KN4CK3R/TestRepo/issues/1@localhost>
Subject: Re: [KN4CK3R/TestRepo] Test (#1)
To: kn4ck3r@gitea.test
X-Auto-Response-Suppress: All
X-GitHub-Reason: issue
X-GitHub-Recipient-Address: kn4ck3r@gitea.test
X-GitHub-Recipient: KN4CK3R
X-GitHub-Sender: KN4CK3R2
X-GitLab-Issue-IID: 1
X-GitLab-NotificationReason: issue
X-GitLab-Project-Path: KN4CK3R/TestRepo
X-GitLab-Project: TestRepo
X-Gitea-Issue-ID: 1
X-Gitea-Issue-Link: http://localhost:3000/KN4CK3R/TestRepo/issues/1
X-Gitea-Reason: issue
X-Gitea-Recipient-Address: kn4ck3r@gitea.test
X-Gitea-Recipient: KN4CK3R
X-Gitea-Repository-Link: http://localhost:3000/KN4CK3R/TestRepo
X-Gitea-Repository-Path: KN4CK3R/TestRepo
X-Gitea-Repository: TestRepo
X-Gitea-Sender: KN4CK3R2
fixes #15926 related #13585, #10808, #13283 Added some custom headers to issue emails to support better filters. See #15926 for details. Like in webhooks I have added `X-GitHub-` and `X-GitLab-` headers too but want your opinion if we want to send them or not. The `...-Reason` header may not match what they are sending. Part of a test mail (sorted): ``` In-Reply-To: <KN4CK3R/TestRepo/issues/1@localhost> List-Archive: <http://localhost:3000/KN4CK3R/TestRepo> List-ID: KN4CK3R/TestRepo <TestRepo.KN4CK3R.localhost> References: <KN4CK3R/TestRepo/issues/1@localhost> Subject: Re: [KN4CK3R/TestRepo] Test (#1) To: kn4ck3r@gitea.test X-Auto-Response-Suppress: All X-GitHub-Reason: issue X-GitHub-Recipient-Address: kn4ck3r@gitea.test X-GitHub-Recipient: KN4CK3R X-GitHub-Sender: KN4CK3R2 X-GitLab-Issue-IID: 1 X-GitLab-NotificationReason: issue X-GitLab-Project-Path: KN4CK3R/TestRepo X-GitLab-Project: TestRepo X-Gitea-Issue-ID: 1 X-Gitea-Issue-Link: http://localhost:3000/KN4CK3R/TestRepo/issues/1 X-Gitea-Reason: issue X-Gitea-Recipient-Address: kn4ck3r@gitea.test X-Gitea-Recipient: KN4CK3R X-Gitea-Repository-Link: http://localhost:3000/KN4CK3R/TestRepo X-Gitea-Repository-Path: KN4CK3R/TestRepo X-Gitea-Repository: TestRepo X-Gitea-Sender: KN4CK3R2 ```
silverwind (Migrated from github.com) reviewed 2021-05-21 14:19:58 +00:00
silverwind (Migrated from github.com) commented 2021-05-21 14:19:58 +00:00

IID is no typo, right?

`IID` is no typo, right?
KN4CK3R (Migrated from github.com) reviewed 2021-05-21 15:11:29 +00:00
KN4CK3R (Migrated from github.com) commented 2021-05-21 15:11:29 +00:00

No typo. They use IID for the repo specific count (Issue 1) and ID for the internal/database id.

No typo. They use `IID` for the repo specific count (Issue 1) and `ID` for the internal/database id.
silverwind (Migrated from github.com) approved these changes 2021-05-21 16:17:00 +00:00
lunny approved these changes 2021-05-22 03:17:33 +00:00
This repo is archived. You cannot comment on pull requests.
No reviewers
No Milestone
No project
No Assignees
1 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: lunny/gitea#15939
No description provided.