Make the github migration less rate limit waiting to get comment per page from repository but not per issue #16070

lunny · 2021-06-05T03:27:54Z

lunny commented

2021-06-05 03:27:54 +00:00

Since most issue/pr's comments are less than 100 but github rate limit is via request times. So if every time we can get 100 comments, we will request less.

This PR we use another github API to not send issue/pr's index to get comments but just get repository's comments.

Since most issue/pr's comments are less than 100 but github rate limit is via request times. So if every time we can get 100 comments, we will request less. This PR we use another github API to not send issue/pr's index to get comments but just get repository's comments.

👍 1

zeripath reviewed 2021-06-06 10:01:49 +00:00

modules/migrations/base/downloader.go

zeripath commented

2021-06-06 10:01:49 +00:00

This is kinda at odds with the rest of this interface whereby if something is not supported it usually returns an ErrNotSupported.

It would probably be more consistent to provide a GetAllComments function instead that most migrators would ErrNotSupport and if so we fallback to GetComments(issueNumber) and GetAllComments which Github would support that would mean we could do the all comments route instead. Otherwise this is kinda inconsistent.

This is kinda at odds with the rest of this interface whereby if something is not supported it usually returns an ErrNotSupported. It would probably be more consistent to provide a GetAllComments function instead that most migrators would ErrNotSupport and if so we fallback to GetComments(issueNumber) and GetAllComments which Github would support that would mean we could do the all comments route instead. Otherwise this is kinda inconsistent.

lunny reviewed 2021-06-06 11:32:16 +00:00

modules/migrations/base/downloader.go

lunny commented

2021-06-06 11:32:16 +00:00

The GetAllComments have to invoke after GetIssues and GetPullRequests. But GetComment should be invoked after every issue or pull request. So we cannot try GetAllComments at first.

The `GetAllComments` have to invoke after `GetIssues` and `GetPullRequests`. But `GetComment` should be invoked after every issue or pull request. So we cannot try `GetAllComments` at first.