Add sso.Group, context.Auth, context.APIAuth to allow auth special routes #16086

lunny · 2021-06-06T09:25:39Z

lunny commented

2021-06-06 09:25:39 +00:00

This PR is only a refactor, but it makes auth according different routes possible.

👍 1

zeripath approved these changes 2021-06-08 06:17:16 +00:00

zeripath left a comment

Thanks this is the start of the refactor of the SSO methods I wanted to do but got stalled in earlier.

Few comments for more steps which can wait for the next pr but some of which could be done now

Thanks this is the start of the refactor of the SSO methods I wanted to do but got stalled in earlier. Few comments for more steps which can wait for the next pr but some of which could be done now

services/auth/interface.go

						
				@ -0,0 +26,4 @@

					// in order to allow the plugin to allocate necessary resources

					Init() error

					// Free should be called exactly once before application closes, in order to

zeripath commented

2021-06-08 06:03:40 +00:00

Could probably be better just named authenticate or verify

zeripath commented

2021-06-08 06:14:51 +00:00

We should think about whether we need this.

It could be rolled into the verifyauthdata function quite easily thus reducing complexity in the functions that call it, or (likely better) the methods groups could be constructed with only enabled methods enabled

Once we have the groups peppered within the routes we should then simplify the rest of these methods to remove the URL testing within methods.

We should think about whether we need this. It could be rolled into the verifyauthdata function quite easily thus reducing complexity in the functions that call it, or (likely better) the methods groups could be constructed with only enabled methods enabled Once we have the groups peppered within the routes we should then simplify the rest of these methods to remove the URL testing within methods.

 @ -0,0 +30,4 @@
 	// give chance to the plugin to free any allocated resources
 	Free() error
 	// Verify tries to verify the authentication data contained in the request.