Support custom mime type mapping for text files #16304

jpraet · 2021-06-29T21:16:24Z

jpraet commented

2021-06-29 21:16:24 +00:00

In #15133 a repository.mimetype_mapping configuration was added, but it is currently only applied for binary files.
This PR also applies the custom mime type mappings for text files.

Fixes #8152

⚠️ WARNING ⚠️

Enabling this feature may have security implications. Administrators should carefully consider which mimetypes they wish to map.

In #15133 a `repository.mimetype_mapping` configuration was added, but it is currently only applied for binary files. This PR also applies the custom mime type mappings for text files. Fixes #8152 ## :warning: WARNING :warning: Enabling this feature may have security implications. Administrators should carefully consider which mimetypes they wish to map.

6543 (Migrated from github.com) approved these changes 2021-06-29 22:38:44 +00:00

KN4CK3R (Migrated from github.com) reviewed 2021-06-30 06:21:46 +00:00

routers/common/repo.go

KN4CK3R (Migrated from github.com) commented

2021-06-30 06:21:46 +00:00

		if mappedMimeType == "" {
			mappedMimeType = "text/plain"
		}
		ctx.Resp.Header().Set("Content-Type", mappedMimeType+"; charset="+strings.ToLower(cs))

```suggestion if mappedMimeType == "" { mappedMimeType = "text/plain" } ctx.Resp.Header().Set("Content-Type", mappedMimeType+"; charset="+strings.ToLower(cs)) ```