lunny/gitea

Archived

Detect encoding changes while parsing diff #16330

Merged

lunny merged 5 commits from #16329-diff-encoding into main

2021-07-13 01:13:53 +00:00

jpraet commented

2021-07-03 10:58:54 +00:00

Contributor

Independently detect encoding of added, deleted and unchanged sections of each file diff.

Before:

After:

Fix #16329 Independently detect encoding of added, deleted and unchanged sections of each file diff. Before: ![afbeelding](https://user-images.githubusercontent.com/2212615/124351996-f3e4d080-dbfd-11eb-91fc-7341c1076a1c.png) After: ![afbeelding](https://user-images.githubusercontent.com/2212615/124351983-df083d00-dbfd-11eb-891b-a3c134a1968a.png)

lunny approved these changes 2021-07-04 09:49:22 +00:00

6543 (Migrated from github.com) reviewed 2021-07-12 23:03:58 +00:00

services/gitdiff/gitdiff.go

						
				@ -883,35 +884,46 @@ parsingLoop:

					}

6543 (Migrated from github.com) commented

2021-07-12 23:03:57 +00:00

Owner

	// TODO: There are numerous issues with this:

```suggestion // TODO: There are numerous issues with this: ```

6543 (Migrated from github.com) approved these changes 2021-07-12 23:57:09 +00:00

This repo is archived. You cannot comment on pull requests.

No reviewers

No Label

good first issue

hacktoberfest-accepted

kind/deployment

kind/deprecated

kind/enhancement

kind/moderation

kind/regression

kind/translation

kind/upstream-related

performance/bigrepo

performance/cpu

performance/memory

performance/speed

priority/critical

priority/medium

proposal/rejected

reviewed/confirmed

reviewed/duplicate

reviewed/invalid

reviewed/not-a-bug

reviewed/wontfix

status/needs-feedback

theme/authentication

theme/backup-restore

theme/federation

theme/migration

theme/timetracker

No Milestone

No project

No Assignees

2 Participants

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: lunny/gitea#16330

No description provided.