Let branch/tag name be a valid ref to get CI status #16400

zeripath · 2021-07-11T20:55:03Z

6543 commented

2021-07-11 20:55:03 +00:00

(Migrated from github.com)

fix #16384

noerw (Migrated from github.com) approved these changes 2021-07-12 08:24:30 +00:00

zeripath reviewed 2021-07-12 20:38:37 +00:00

routers/api/v1/utils/git.go

zeripath commented

2021-07-12 20:38:37 +00:00

should check if the ctx.Repo.GitRepo is set and if so use that

zeripath reviewed 2021-07-12 20:39:28 +00:00

routers/api/v1/utils/git.go

						
				@ -0,0 +2,4 @@

				// Use of this source code is governed by a MIT-style

				// license that can be found in the LICENSE file.

				package utils

zeripath commented

2021-07-12 20:39:28 +00:00

As lunny worried utils is becoming a bit of a catch-all package. Not necessarily this PR but I wonder if we these would be better in a git package.

zeripath reviewed 2021-07-12 20:41:02 +00:00

routers/api/v1/utils/git.go

						
				@ -0,0 +19,4 @@

					}

					// Search branches and tags

					for _, refType := range []string{"heads", "tags"} {

zeripath commented

2021-07-12 20:40:54 +00:00

Now a branch named deadbeef will override the sha deadbeef. I'm not sure if that's completely intentional, it may be best to provide some marker or mechanism to force sha over branches/tags

6543 (Migrated from github.com) reviewed 2021-07-12 22:39:07 +00:00

routers/api/v1/utils/git.go

						
				@ -0,0 +19,4 @@

					}

					// Search branches and tags

					for _, refType := range []string{"heads", "tags"} {

6543 (Migrated from github.com) commented

2021-07-12 22:39:07 +00:00

well this is how it works now for statuses and changing it would be to much for this bugfix

well this is how it works now for status**es** and changing it would be to much for this **bugfix**

6543 (Migrated from github.com) reviewed 2021-07-12 22:39:53 +00:00

routers/api/v1/utils/git.go

						
				@ -0,0 +2,4 @@

				// Use of this source code is governed by a MIT-style

				// license that can be found in the LICENSE file.

				package utils

6543 (Migrated from github.com) commented

2021-07-12 22:39:53 +00:00

will create an issue, this is a bugfix not a whole refactor ... you can find more similar code (git ref -> sha lookup) all over different places and we should unify them

6543 (Migrated from github.com) reviewed 2021-07-12 22:42:12 +00:00

routers/api/v1/utils/git.go

						
				@ -0,0 +2,4 @@

				// Use of this source code is governed by a MIT-style

				// license that can be found in the LICENSE file.

				package utils

6543 (Migrated from github.com) commented

2021-07-12 22:42:12 +00:00

-> #16411

6543 (Migrated from github.com) reviewed 2021-07-12 22:42:18 +00:00

routers/api/v1/utils/git.go

						
				@ -0,0 +19,4 @@

					}

					// Search branches and tags

					for _, refType := range []string{"heads", "tags"} {

6543 (Migrated from github.com) commented

2021-07-12 22:42:18 +00:00

-> #16411

6543 (Migrated from github.com) reviewed 2021-07-12 22:42:53 +00:00

routers/api/v1/utils/git.go

6543 (Migrated from github.com) commented

2021-07-12 22:42:53 +00:00

well it original did not work this way but will add this optimisation

zeripath approved these changes 2021-07-13 07:14:06 +00:00

This repo is archived. You cannot comment on pull requests.

No reviewers

noerw

No Label

hacktoberfest-accepted

kind/upstream-related

status/needs-feedback

No Milestone

No project

No Assignees

2 Participants

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: lunny/gitea#16400