Improve dashboard repo search #1652

lunny · 2017-05-01T14:23:34Z

andreynering commented

2017-05-01 14:23:34 +00:00

(Migrated from github.com)

Improvement of https://github.com/go-gitea/gitea/pull/872

I think the last thing to discuss is wether we should remove the other repo panels, since this one now show all repos visible to the logged in user.

Improvement of https://github.com/go-gitea/gitea/pull/872 I think the last thing to discuss is wether we should remove the other repo panels, since this one now show all repos visible to the logged in user.

bkcsoft commented

2017-05-03 01:14:03 +00:00

(Migrated from github.com)

well, LGTM to me, as for removing the other panel I'm fine with that ?

lunny commented

2017-05-04 06:49:05 +00:00

This is my screenshot. It seems it's not ready?

This is my screenshot. It seems it's not ready? ![untitled](https://cloud.githubusercontent.com/assets/81045/25692939/c112e158-30d8-11e7-8cf8-65eb55bfc08b.png)

andreynering commented

2017-05-04 10:22:17 +00:00

(Migrated from github.com)

@lunny Not sure what could be wrong, it works for me.

Did you run make assets? Any error on the JS console?

@lunny Not sure what could be wrong, it works for me. Did you run `make assets`? Any error on the JS console?

lunny commented

2017-05-04 11:48:01 +00:00

I didn't run make assets, make: Nothing to be done for assets'.`.

I didn't run `make assets`, `make: Nothing to be done for `assets'.`.

andreynering commented

2017-05-04 14:11:55 +00:00

(Migrated from github.com)

@lunny Sorry, make assets by now is just for CSS, not JS.

If you are compiling with bindata you should run make generate.

Can also be a an cache issue. Otherwise, I don't know what's the problem. ?

@lunny Sorry, `make assets` by now is just for CSS, not JS. If you are compiling with bindata you should run `make generate`. Can also be a an cache issue. Otherwise, I don't know what's the problem. ?

andreynering commented

2017-05-06 13:38:43 +00:00

(Migrated from github.com)

Updated. I fixed an issue with the repos/orgs/mirrors tabs switching.

@bkcsoft I decided to keep the other panel for now, because the api is not yet showing repos you're just a colaborator and not owner. That panel shows exactly that. We could change that in another PR.

@lunny Which browser are you using? Any errors on JS console?

Updated. I fixed an issue with the repos/orgs/mirrors tabs switching. @bkcsoft I decided to keep the other panel for now, because the api is not yet showing repos you're just a colaborator and not owner. That panel shows exactly that. We could change that in another PR. @lunny Which browser are you using? Any errors on JS console?

lunny commented

2017-05-07 04:23:18 +00:00

I used chrome on Mac OS. but seems it fixed when I update to the latest commit of this PR.

lunny commented

2017-05-07 04:23:24 +00:00

so LGTM

lunny commented

2017-05-07 04:26:04 +00:00

let L-G-T-M work

lunny commented

2017-05-07 04:27:09 +00:00

don't merge this until v1.2 released.

bkcsoft commented

2017-05-08 06:45:59 +00:00

(Migrated from github.com)

@lunny Why wait until after 1.2? (Added status/blocked in the meanwhile)

@lunny Why wait until after 1.2? (Added `status/blocked` in the meanwhile)

lunny commented

2017-05-08 08:26:08 +00:00

I don't know. @andreynering maybe we can put it back to v1.2 since this is not a big feature.

andreynering commented

2017-05-08 20:55:44 +00:00

(Migrated from github.com)

I'm ok with that

Em 08/05/2017 5:26 AM, "Lunny Xiao" notifications@github.com escreveu:

I don't know. @andreynering https://github.com/andreynering maybe we
can put it back to v1.2 since this is not a big feature.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/go-gitea/gitea/pull/1652#issuecomment-299804652, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AGr966V2uU8iOYGh6xKsuuGsIt7rDtwSks5r3tGigaJpZM4NNE-9
.

I'm ok with that Em 08/05/2017 5:26 AM, "Lunny Xiao" <notifications@github.com> escreveu: > I don't know. @andreynering <https://github.com/andreynering> maybe we > can put it back to v1.2 since this is not a big feature. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/go-gitea/gitea/pull/1652#issuecomment-299804652>, or mute > the thread > <https://github.com/notifications/unsubscribe-auth/AGr966V2uU8iOYGh6xKsuuGsIt7rDtwSks5r3tGigaJpZM4NNE-9> > . >

This repo is archived. You cannot comment on pull requests.

No reviewers