Restore compatibility with SQLServer 2008 R2 in migrations (#16627) #16638

zeripath · 2021-08-06T08:55:27Z

zeripath commented

2021-08-06 08:55:27 +00:00

Backport #16627

This fixes two problems with MSSQL:

ALTER TABLE DROP ... IF EXISTS ... is only supported in SQL Server >16.

The IF EXISTS here is a belt-and-braces and does not need to be present. Therefore
can be dropped. Also stop attempting to drop the indexes as constraints as they're indexes!

System tables like: sys.indexes should be lowercase not uppercase because of collation issues.

Fix #16625
Fix #13615
Fix #16483

Signed-off-by: Andrew Thornton art27@cantab.net

Backport #16627 This fixes two problems with MSSQL: * `ALTER TABLE DROP ... IF EXISTS ...` is only supported in SQL Server >16. The `IF EXISTS` here is a belt-and-braces and does not need to be present. Therefore can be dropped. Also stop attempting to drop the indexes as constraints as they're indexes! * System tables like: `sys.indexes` should be lowercase not uppercase because of collation issues. Fix #16625 Fix #13615 Fix #16483 Signed-off-by: Andrew Thornton <art27@cantab.net>