lunny/gitea

Archived

Remove the final test from the testlogger safely #16907

Merged

lunny merged 3 commits from prevent-data-race-during-test-shutdown into main

2021-09-01 13:05:05 +00:00

zeripath commented

2021-08-31 19:04:27 +00:00

Contributor

It is possible to get a data race right at the end of the TestMain
in integrations during the final removal of the test from the testlogger. This PR
uses a Reset function to remove any final tests but adds some extra
logging which will forcibly fail if there is an unclosed logger.

Related #1441

Signed-off-by: Andrew Thornton art27@cantab.net

It is possible to get a data race right at the end of the TestMain in integrations during the final removal of the test from the testlogger. This PR uses a Reset function to remove any final tests but adds some extra logging which will forcibly fail if there is an unclosed logger. Related #1441 Signed-off-by: Andrew Thornton <art27@cantab.net>

lafriks (Migrated from github.com) approved these changes 2021-08-31 20:43:59 +00:00

KN4CK3R (Migrated from github.com) approved these changes 2021-09-01 07:45:36 +00:00

This repo is archived. You cannot comment on pull requests.

No reviewers

No Label

good first issue

hacktoberfest-accepted

kind/deployment

kind/deprecated

kind/enhancement

kind/moderation

kind/regression

kind/translation

kind/upstream-related

performance/bigrepo

performance/cpu

performance/memory

performance/speed

priority/critical

priority/medium

proposal/rejected

reviewed/confirmed

reviewed/duplicate

reviewed/invalid

reviewed/not-a-bug

reviewed/wontfix

status/needs-feedback

theme/authentication

theme/backup-restore

theme/federation

theme/migration

theme/timetracker

No Milestone

No project

No Assignees

2 Participants

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: lunny/gitea#16907

No description provided.