Add API to get commit diff/patch #17095

qwerty287 · 2021-09-19T16:14:26Z

qwerty287 commented

2021-09-19 16:14:26 +00:00

This PR adds an API endpoint to get the diff or patch file of a commit. It uses the same mechanism as the "site" <host>/<owner>/<repo>/commit/<sha>.<diff or patch>.

Endpoints:
Get diff /repos/{owner}/{repo}/git/commits/{sha}.diff
Get patch /repos/{owner}/{repo}/git/commits/{sha}.patch

Could close #10921 #13012

This PR adds an API endpoint to get the diff or patch file of a commit. It uses the same mechanism as the "site" `<host>/<owner>/<repo>/commit/<sha>.<diff or patch>`. Endpoints: Get diff `/repos/{owner}/{repo}/git/commits/{sha}.diff` Get patch `/repos/{owner}/{repo}/git/commits/{sha}.patch` Could close #10921 #13012

6543 (Migrated from github.com) reviewed 2021-09-19 16:43:10 +00:00

routers/api/v1/api.go

6543 (Migrated from github.com) commented

2021-09-19 16:43:09 +00:00

						m.Get("/{sha}.{diffType:diff|patch}",

can we unify that function directly within the router - so we only have one new endpoint

```suggestion m.Get("/{sha}.{diffType:diff|patch}", ``` can we unify that function directly within the router - so we only have one new endpoint

6543 (Migrated from github.com) reviewed 2021-09-19 16:44:36 +00:00

routers/api/v1/repo/commits.go

6543 (Migrated from github.com) commented

2021-09-19 16:44:36 +00:00

	// - name: diffType
	//   in: path
	//   type: string
	...
	// responses:

```suggestion // - name: diffType // in: path // type: string ... // responses: ```

6543 (Migrated from github.com) reviewed 2021-09-19 16:45:08 +00:00

routers/api/v1/repo/commits.go

6543 (Migrated from github.com) commented

2021-09-19 16:45:08 +00:00

(needed for unify)

qwerty287 reviewed 2021-09-19 16:49:21 +00:00

routers/api/v1/api.go

qwerty287 commented

2021-09-19 16:49:21 +00:00

I'll look into this, just wait a moment ?

qwerty287 reviewed 2021-09-19 17:16:22 +00:00

routers/api/v1/api.go

qwerty287 commented

2021-09-19 17:16:22 +00:00

I merged them and it works... But make generate-swagger doesn't work. It always returns (the swagger JSON in the commit is something I tried to resolve it, but it's not that what it should be):

operation (repoDownloadCommitDiffOrPatch): yaml: line 21: did not find expected key
exit status 1

I merged them and it works... But `make generate-swagger` doesn't work. It always returns (the swagger JSON in the commit is something I tried to resolve it, but it's not that what it should be): ``` operation (repoDownloadCommitDiffOrPatch): yaml: line 21: did not find expected key exit status 1 ```