API: don't allow merged PRs to be reopened #17192

jolheiser · 2021-09-30T13:21:19Z

noerw commented

2021-09-30 13:21:19 +00:00

(Migrated from github.com)

I tried to add tests, but didn't find a way to merge a pull request without introducing a race condition in testing (pr.CanAutoMerge() blocks merging right away). If you have any hints, I'll add tests

fix #17180 I tried to add tests, but didn't find a way to merge a pull request without introducing a race condition in testing (`pr.CanAutoMerge()` blocks merging right away). If you have any hints, I'll add tests

6543 (Migrated from github.com) reviewed 2021-09-30 16:30:50 +00:00

routers/api/v1/repo/pull.go

6543 (Migrated from github.com) commented

2021-09-30 16:30:50 +00:00

hmm this way you can "close" a mreged pull ... shoulw we simple check if HasMerged and deny any state change?

noerw (Migrated from github.com) reviewed 2021-09-30 16:32:33 +00:00

routers/api/v1/repo/pull.go

noerw (Migrated from github.com) commented

2021-09-30 16:32:33 +00:00

Not sure if this is a state we can ever get into, but we can make the check more general.
btw, I also just noticed that we need to account for this in EditIssue() as well.. will add that later

Not sure if this is a state we can ever get into, but we can make the check more general. btw, I also just noticed that we need to account for this in `EditIssue()` as well.. will add that later