Nil Pointer 500 in compare view #17193

New Issue

2021-09-30T14:11:56Z

6543 commented

2021-09-30 14:11:56 +00:00

(Migrated from github.com)

Gitea Info

version: main (3bbdce2)
git: v33.0
os: linux

Gist

PANIC: runtime error: invalid memory address or nil pointer dereference
/usr/lib/go/src/runtime/panic.go:221 (0x44da46)
	panicmem: panic(memoryError)
/usr/lib/go/src/runtime/signal_unix.go:735 (0x44da16)
	sigpanic: panicmem()
/home/maddl/git/own/gitea/routers/web/repo/compare.go:638 (0x1ba4378)
	CompareDiff.func1: if ci.HeadGitRepo != nil {
/home/maddl/git/own/gitea/routers/web/repo/compare.go:643 (0x1ba42cc)
	CompareDiff: return
/home/maddl/git/own/gitea/modules/web/route.go:74 (0x1b53cc4)
	Wrap.func1: t(ctx)
/usr/lib/go/src/net/http/server.go:2046 (0x76190e)
	HandlerFunc.ServeHTTP: f(w, r)
/home/maddl/git/own/gitea/vendor/github.com/go-chi/chi/mux.go:436 (0x138cb58)
	(*Mux).routeHTTP: h.ServeHTTP(w, r)
/usr/lib/go/src/net/http/server.go:2046 (0x76190e)
	HandlerFunc.ServeHTTP: f(w, r)
/home/maddl/git/own/gitea/modules/web/route.go:113 (0x1b544a5)
	Middle.func1.1: next.ServeHTTP(ctx.Resp, ctx.Req)
/usr/lib/go/src/net/http/server.go:2046 (0x76190e)
	HandlerFunc.ServeHTTP: f(w, r)
/home/maddl/git/own/gitea/modules/web/route.go:113 (0x1b544a5)
	Middle.func1.1: next.ServeHTTP(ctx.Resp, ctx.Req)
/usr/lib/go/src/net/http/server.go:2046 (0x76190e)
	HandlerFunc.ServeHTTP: f(w, r)
/home/maddl/git/own/gitea/modules/web/route.go:113 (0x1b544a5)
	Middle.func1.1: next.ServeHTTP(ctx.Resp, ctx.Req)
/usr/lib/go/src/net/http/server.go:2046 (0x76190e)
	HandlerFunc.ServeHTTP: f(w, r)
/home/maddl/git/own/gitea/vendor/github.com/go-chi/chi/middleware/get_head.go:37 (0x1b71304)
	GetHead.func1: next.ServeHTTP(w, r)
/usr/lib/go/src/net/http/server.go:2046 (0x76190e)
	HandlerFunc.ServeHTTP: f(w, r)
/home/maddl/git/own/gitea/modules/web/route.go:113 (0x1b544a5)
	Middle.func1.1: next.ServeHTTP(ctx.Resp, ctx.Req)
/usr/lib/go/src/net/http/server.go:2046 (0x76190e)
	HandlerFunc.ServeHTTP: f(w, r)
/home/maddl/git/own/gitea/modules/context/context.go:747 (0x139dedb)
	Contexter.func1.1: next.ServeHTTP(ctx.Resp, ctx.Req)
/usr/lib/go/src/net/http/server.go:2046 (0x76190e)
	HandlerFunc.ServeHTTP: f(w, r)
/home/maddl/git/own/gitea/vendor/github.com/go-chi/chi/mux.go:70 (0x138a9ad)
	(*Mux).ServeHTTP: mx.handler.ServeHTTP(w, r)
/home/maddl/git/own/gitea/vendor/github.com/go-chi/chi/mux.go:311 (0x138c35b)

Description

should return 404

### Gitea Info version: main (3bbdce2) git: v33.0 os: linux # Gist ``` PANIC: runtime error: invalid memory address or nil pointer dereference /usr/lib/go/src/runtime/panic.go:221 (0x44da46) panicmem: panic(memoryError) /usr/lib/go/src/runtime/signal_unix.go:735 (0x44da16) sigpanic: panicmem() /home/maddl/git/own/gitea/routers/web/repo/compare.go:638 (0x1ba4378) CompareDiff.func1: if ci.HeadGitRepo != nil { /home/maddl/git/own/gitea/routers/web/repo/compare.go:643 (0x1ba42cc) CompareDiff: return /home/maddl/git/own/gitea/modules/web/route.go:74 (0x1b53cc4) Wrap.func1: t(ctx) /usr/lib/go/src/net/http/server.go:2046 (0x76190e) HandlerFunc.ServeHTTP: f(w, r) /home/maddl/git/own/gitea/vendor/github.com/go-chi/chi/mux.go:436 (0x138cb58) (*Mux).routeHTTP: h.ServeHTTP(w, r) /usr/lib/go/src/net/http/server.go:2046 (0x76190e) HandlerFunc.ServeHTTP: f(w, r) /home/maddl/git/own/gitea/modules/web/route.go:113 (0x1b544a5) Middle.func1.1: next.ServeHTTP(ctx.Resp, ctx.Req) /usr/lib/go/src/net/http/server.go:2046 (0x76190e) HandlerFunc.ServeHTTP: f(w, r) /home/maddl/git/own/gitea/modules/web/route.go:113 (0x1b544a5) Middle.func1.1: next.ServeHTTP(ctx.Resp, ctx.Req) /usr/lib/go/src/net/http/server.go:2046 (0x76190e) HandlerFunc.ServeHTTP: f(w, r) /home/maddl/git/own/gitea/modules/web/route.go:113 (0x1b544a5) Middle.func1.1: next.ServeHTTP(ctx.Resp, ctx.Req) /usr/lib/go/src/net/http/server.go:2046 (0x76190e) HandlerFunc.ServeHTTP: f(w, r) /home/maddl/git/own/gitea/vendor/github.com/go-chi/chi/middleware/get_head.go:37 (0x1b71304) GetHead.func1: next.ServeHTTP(w, r) /usr/lib/go/src/net/http/server.go:2046 (0x76190e) HandlerFunc.ServeHTTP: f(w, r) /home/maddl/git/own/gitea/modules/web/route.go:113 (0x1b544a5) Middle.func1.1: next.ServeHTTP(ctx.Resp, ctx.Req) /usr/lib/go/src/net/http/server.go:2046 (0x76190e) HandlerFunc.ServeHTTP: f(w, r) /home/maddl/git/own/gitea/modules/context/context.go:747 (0x139dedb) Contexter.func1.1: next.ServeHTTP(ctx.Resp, ctx.Req) /usr/lib/go/src/net/http/server.go:2046 (0x76190e) HandlerFunc.ServeHTTP: f(w, r) /home/maddl/git/own/gitea/vendor/github.com/go-chi/chi/mux.go:70 (0x138a9ad) (*Mux).ServeHTTP: mx.handler.ServeHTTP(w, r) /home/maddl/git/own/gitea/vendor/github.com/go-chi/chi/mux.go:311 (0x138c35b) ``` ### Description should return 404