lunny/gitea

Archived

Switch to keybase go-crypto (for some elliptic curve key) + test #1925

Merged

sapk merged 3 commits from test-brainpoolP256r1-key into master

2017-06-14 00:43:43 +00:00

sapk commented

2017-06-10 00:09:48 +00:00

(Migrated from github.com)

Fix #1898 by using keybase/go-crypto in place of golang.org/x/crypto.

In folder openpgp, keybase/go-crypto is not that far away of golang.org/x/crypto and implement more key type.

Fix #1898 by using keybase/go-crypto in place of golang.org/x/crypto. In folder openpgp, keybase/go-crypto is not that far away of golang.org/x/crypto and implement more key type.

bkcsoft commented

2017-06-11 07:40:10 +00:00

(Migrated from github.com)

LGTM. Though I'd prefer go-crypto/openpgp to be merged into stdlib ?

LGTM. Though I'd prefer go-crypto/openpgp to be merged into stdlib ?

ethantkoenig (Migrated from github.com) requested changes 2017-06-12 22:07:09 +00:00

models/gpg_key_test.go

						
				@ -44,3 +44,3 @@

					key, err := checkArmoredGPGKeyString(testGPGArmor)

					assert.Nil(t, err, "Could not parse a valid GPG armored key", key)

					assert.NoError(t, err, "Could not parse a valid GPG public armored rsa key", key)

ethantkoenig (Migrated from github.com) commented

2017-06-12 22:06:37 +00:00

For checking errors, you should use assert.NoError(..)

For checking errors, you should use `assert.NoError(..)`

ethantkoenig (Migrated from github.com) approved these changes 2017-06-13 13:28:47 +00:00

sapk (Migrated from github.com) reviewed 2017-06-13 13:34:53 +00:00

models/gpg_key_test.go

						
				@ -44,3 +44,3 @@

					key, err := checkArmoredGPGKeyString(testGPGArmor)

					assert.Nil(t, err, "Could not parse a valid GPG armored key", key)

					assert.NoError(t, err, "Could not parse a valid GPG public armored rsa key", key)

sapk (Migrated from github.com) commented

2017-06-13 13:34:53 +00:00

done and update all test in this file to use .Error .NotError

done and update all test in this file to use .Error .NotError

Bwko commented

2017-06-13 21:00:21 +00:00

(Migrated from github.com)

LGTM

LGTM

This repo is archived. You cannot comment on pull requests.

No reviewers

No Label

good first issue

hacktoberfest-accepted

kind/deployment

kind/deprecated

kind/enhancement

kind/moderation

kind/regression

kind/translation

kind/upstream-related

performance/bigrepo

performance/cpu

performance/memory

performance/speed

priority/critical

priority/medium

proposal/rejected

reviewed/confirmed

reviewed/duplicate

reviewed/invalid

reviewed/not-a-bug

reviewed/wontfix

status/needs-feedback

theme/authentication

theme/backup-restore

theme/federation

theme/migration

theme/timetracker

No Milestone

No project

No Assignees

1 Participants

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: lunny/gitea#1925

No description provided.