Fix unit test race condition #2516

lunny · 2017-09-15T05:30:59Z

ethantkoenig commented

2017-09-15 05:30:59 +00:00

(Migrated from github.com)

Test would previously fail if the id had not added to pullRequestQueue within 1 millisecond; it now waits until something is added to the queue (with a 1 second timeout).

See https://drone.gitea.io/go-gitea/gitea/606/6 for an example of the test failing.

Test would previously fail if the id had not added to `pullRequestQueue` within 1 millisecond; it now waits until something is added to the queue (with a 1 second timeout). See https://drone.gitea.io/go-gitea/gitea/606/6 for an example of the test failing.

👍 4

lunny commented

2017-09-15 05:41:14 +00:00

LGTM

codecov-io commented

2017-09-15 05:51:51 +00:00

(Migrated from github.com)

Codecov Report

Merging #2516 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #2516   +/-   ##
======================================
  Coverage    27.7%   27.7%           
======================================
  Files          83      83           
  Lines       16914   16914           
======================================
  Hits         4686    4686           
  Misses      11553   11553           
  Partials      675     675

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbe5058...2cd79e0. Read the comment docs.

# [Codecov](https://codecov.io/gh/go-gitea/gitea/pull/2516?src=pr&el=h1) Report > Merging [#2516](https://codecov.io/gh/go-gitea/gitea/pull/2516?src=pr&el=desc) into [master](https://codecov.io/gh/go-gitea/gitea/commit/cbe50587bafa0a807de128f9c3541ba922fbd2f8?src=pr&el=desc) will **not change** coverage. > The diff coverage is `n/a`. [![Impacted file tree graph](https://codecov.io/gh/go-gitea/gitea/pull/2516/graphs/tree.svg?width=650&src=pr&token=t1G57YGbPy&height=150)](https://codecov.io/gh/go-gitea/gitea/pull/2516?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #2516 +/- ## ====================================== Coverage 27.7% 27.7% ====================================== Files 83 83 Lines 16914 16914 ====================================== Hits 4686 4686 Misses 11553 11553 Partials 675 675 ``` ------ [Continue to review full report at Codecov](https://codecov.io/gh/go-gitea/gitea/pull/2516?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/go-gitea/gitea/pull/2516?src=pr&el=footer). Last update [cbe5058...2cd79e0](https://codecov.io/gh/go-gitea/gitea/pull/2516?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

lafriks commented

2017-09-15 06:09:44 +00:00

(Migrated from github.com)

LGTM

This repo is archived. You cannot comment on pull requests.

No reviewers