Fix language names #2955

appleboy · 2017-11-21T22:54:10Z

0rzech commented

2017-11-21 22:54:10 +00:00

(Migrated from github.com)

Make language names grammatical in defaults.go and app.ini.

codecov-io commented

2017-11-21 23:01:27 +00:00

(Migrated from github.com)

Codecov Report

Merging #2955 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2955      +/-   ##
==========================================
+ Coverage    26.8%   26.82%   +0.01%     
==========================================
  Files          90       90              
  Lines       17807    17807              
==========================================
+ Hits         4774     4777       +3     
+ Misses      12353    12351       -2     
+ Partials      680      679       -1

Impacted Files	Coverage Δ
modules/process/manager.go	`73.91% <0%> (+4.34%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42d781a...4ab99c1. Read the comment docs.

# [Codecov](https://codecov.io/gh/go-gitea/gitea/pull/2955?src=pr&el=h1) Report > Merging [#2955](https://codecov.io/gh/go-gitea/gitea/pull/2955?src=pr&el=desc) into [master](https://codecov.io/gh/go-gitea/gitea/commit/42d781a709f2919b13f9f75be83e53910f5a6c83?src=pr&el=desc) will **increase** coverage by `0.01%`. > The diff coverage is `n/a`. [![Impacted file tree graph](https://codecov.io/gh/go-gitea/gitea/pull/2955/graphs/tree.svg?token=t1G57YGbPy&width=650&height=150&src=pr)](https://codecov.io/gh/go-gitea/gitea/pull/2955?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #2955 +/- ## ========================================== + Coverage 26.8% 26.82% +0.01% ========================================== Files 90 90 Lines 17807 17807 ========================================== + Hits 4774 4777 +3 + Misses 12353 12351 -2 + Partials 680 679 -1 ``` | [Impacted Files](https://codecov.io/gh/go-gitea/gitea/pull/2955?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [modules/process/manager.go](https://codecov.io/gh/go-gitea/gitea/pull/2955?src=pr&el=tree#diff-bW9kdWxlcy9wcm9jZXNzL21hbmFnZXIuZ28=) | `73.91% <0%> (+4.34%)` | :arrow_up: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/go-gitea/gitea/pull/2955?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/go-gitea/gitea/pull/2955?src=pr&el=footer). Last update [42d781a...4ab99c1](https://codecov.io/gh/go-gitea/gitea/pull/2955?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

ethantkoenig commented

2017-11-22 03:31:37 +00:00

(Migrated from github.com)

LGTM

appleboy approved these changes 2017-11-22 03:38:31 +00:00

appleboy commented

2017-11-22 03:39:25 +00:00

LGTM

lafriks commented

2017-11-22 06:26:38 +00:00

(Migrated from github.com)

Please rebase

sapk commented

2017-11-22 07:22:44 +00:00

(Migrated from github.com)

Why dropping the capitalization on some ?

lafriks commented

2017-11-22 07:44:36 +00:00

(Migrated from github.com)

@sapk in some languages language names are not written capitalized as in English. At least I can confirm this is correct for Latvian, don't know about others