Set OpenID support on by default when installing new instance #3010

lunny · 2017-11-28T11:42:41Z

strk commented

2017-11-28 11:42:41 +00:00

(Migrated from github.com)

Partially fixes #2984

lunny requested changes 2017-11-28 14:57:16 +00:00

modules/setting/setting.go

lunny commented

2017-11-28 14:57:07 +00:00

But I think this should keep false. For a default installation, the minimal feature rule will keep system safer.

0rzech (Migrated from github.com) reviewed 2017-11-28 16:35:33 +00:00

modules/setting/setting.go

						
				@ -1165,7 +1165,7 @@ func newService() {

					Service.NoReplyAddress = sec.Key("NO_REPLY_ADDRESS").MustString("noreply.example.org")

					sec = Cfg.Section("openid")

0rzech (Migrated from github.com) commented

2017-11-28 16:35:33 +00:00

I think this should simply be

Service.EnableOpenIDSignIn = sec.Key("ENABLE_OPENID_SIGNIN").MustBool(!InstallLock)

because InstallLock state seems to indicate whether this is fresh install or not, while Gitea creates app.ini itself during install process.

I think this should simply be ``` Service.EnableOpenIDSignIn = sec.Key("ENABLE_OPENID_SIGNIN").MustBool(!InstallLock) ``` because `InstallLock` state seems to indicate whether this is fresh install or not, while Gitea creates `app.ini` itself during install process.

lunny approved these changes 2017-11-29 12:44:04 +00:00

lunny commented

2017-11-29 12:44:12 +00:00

LGTM

lafriks commented

2017-11-29 12:45:01 +00:00

(Migrated from github.com)

LGTM

codecov-io commented

2017-11-29 12:47:03 +00:00

(Migrated from github.com)

Codecov Report

Merging #3010 into master will not change coverage.
The diff coverage is 33.33%.

@@           Coverage Diff           @@
##           master    #3010   +/-   ##
=======================================
  Coverage   32.98%   32.98%           
=======================================
  Files         270      270           
  Lines       39534    39534           
=======================================
  Hits        13042    13042           
  Misses      24637    24637           
  Partials     1855     1855

Impacted Files	Coverage Δ
routers/install.go	`0% <0%> (ø)`	⬆️
modules/setting/setting.go	`47.18% <100%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9452c4...68fe411. Read the comment docs.

# [Codecov](https://codecov.io/gh/go-gitea/gitea/pull/3010?src=pr&el=h1) Report > Merging [#3010](https://codecov.io/gh/go-gitea/gitea/pull/3010?src=pr&el=desc) into [master](https://codecov.io/gh/go-gitea/gitea/commit/b9452c48aca6831bebbf471d840ab3e6924c4767?src=pr&el=desc) will **not change** coverage. > The diff coverage is `33.33%`. [![Impacted file tree graph](https://codecov.io/gh/go-gitea/gitea/pull/3010/graphs/tree.svg?src=pr&token=t1G57YGbPy&height=150&width=650)](https://codecov.io/gh/go-gitea/gitea/pull/3010?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #3010 +/- ## ======================================= Coverage 32.98% 32.98% ======================================= Files 270 270 Lines 39534 39534 ======================================= Hits 13042 13042 Misses 24637 24637 Partials 1855 1855 ``` | [Impacted Files](https://codecov.io/gh/go-gitea/gitea/pull/3010?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [routers/install.go](https://codecov.io/gh/go-gitea/gitea/pull/3010?src=pr&el=tree#diff-cm91dGVycy9pbnN0YWxsLmdv) | `0% <0%> (ø)` | :arrow_up: | | [modules/setting/setting.go](https://codecov.io/gh/go-gitea/gitea/pull/3010?src=pr&el=tree#diff-bW9kdWxlcy9zZXR0aW5nL3NldHRpbmcuZ28=) | `47.18% <100%> (ø)` | :arrow_up: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/go-gitea/gitea/pull/3010?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/go-gitea/gitea/pull/3010?src=pr&el=footer). Last update [b9452c4...68fe411](https://codecov.io/gh/go-gitea/gitea/pull/3010?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

lafriks commented

2017-11-29 12:48:02 +00:00

(Migrated from github.com)

@strk please send backport to 1.3

This repo is archived. You cannot comment on pull requests.

No reviewers