Fix column removal in MSSQL #3638

Merged
lafriks merged 3 commits from fix/mssql_drop_column into master 2018-03-07 06:44:13 +00:00
lafriks commented 2018-03-06 21:52:55 +00:00 (Migrated from github.com)

Fixes #3624

Fixes #3624
codecov-io commented 2018-03-06 22:04:47 +00:00 (Migrated from github.com)

Codecov Report

Merging #3638 into master will decrease coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3638      +/-   ##
==========================================
- Coverage   35.92%   35.89%   -0.04%     
==========================================
  Files         286      286              
  Lines       41257    41286      +29     
==========================================
- Hits        14823    14820       -3     
- Misses      24255    24286      +31     
- Partials     2179     2180       +1
Impacted Files Coverage Δ
models/migrations/v56.go 0% <0%> (ø) ⬆️
models/migrations/migrations.go 2.62% <0%> (-0.27%) ⬇️
modules/process/manager.go 76.81% <0%> (-4.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4009c24...8d92ba4. Read the comment docs.

# [Codecov](https://codecov.io/gh/go-gitea/gitea/pull/3638?src=pr&el=h1) Report > Merging [#3638](https://codecov.io/gh/go-gitea/gitea/pull/3638?src=pr&el=desc) into [master](https://codecov.io/gh/go-gitea/gitea/commit/4009c245a367e42f3bc4f76efb8557cfce2d51da?src=pr&el=desc) will **decrease** coverage by `0.03%`. > The diff coverage is `0%`. [![Impacted file tree graph](https://codecov.io/gh/go-gitea/gitea/pull/3638/graphs/tree.svg?height=150&width=650&token=t1G57YGbPy&src=pr)](https://codecov.io/gh/go-gitea/gitea/pull/3638?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #3638 +/- ## ========================================== - Coverage 35.92% 35.89% -0.04% ========================================== Files 286 286 Lines 41257 41286 +29 ========================================== - Hits 14823 14820 -3 - Misses 24255 24286 +31 - Partials 2179 2180 +1 ``` | [Impacted Files](https://codecov.io/gh/go-gitea/gitea/pull/3638?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [models/migrations/v56.go](https://codecov.io/gh/go-gitea/gitea/pull/3638/diff?src=pr&el=tree#diff-bW9kZWxzL21pZ3JhdGlvbnMvdjU2Lmdv) | `0% <0%> (ø)` | :arrow_up: | | [models/migrations/migrations.go](https://codecov.io/gh/go-gitea/gitea/pull/3638/diff?src=pr&el=tree#diff-bW9kZWxzL21pZ3JhdGlvbnMvbWlncmF0aW9ucy5nbw==) | `2.62% <0%> (-0.27%)` | :arrow_down: | | [modules/process/manager.go](https://codecov.io/gh/go-gitea/gitea/pull/3638/diff?src=pr&el=tree#diff-bW9kdWxlcy9wcm9jZXNzL21hbmFnZXIuZ28=) | `76.81% <0%> (-4.35%)` | :arrow_down: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/go-gitea/gitea/pull/3638?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/go-gitea/gitea/pull/3638?src=pr&el=footer). Last update [4009c24...8d92ba4](https://codecov.io/gh/go-gitea/gitea/pull/3638?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
lunny requested changes 2018-03-07 00:54:19 +00:00

How about use a transaction here?

How about use a transaction here?
lafriks (Migrated from github.com) reviewed 2018-03-07 05:36:34 +00:00
lafriks (Migrated from github.com) commented 2018-03-07 05:36:34 +00:00

Alter table is not transactional but I can add it

Alter table is not transactional but I can add it
lafriks commented 2018-03-07 06:18:21 +00:00 (Migrated from github.com)

@lunny done

@lunny done
lunny approved these changes 2018-03-07 06:28:22 +00:00
lafriks commented 2018-03-07 06:37:47 +00:00 (Migrated from github.com)

MSSQL alter table is actually transaction so I added transaction as well

MSSQL alter table is actually transaction so I added transaction as well
appleboy approved these changes 2018-03-07 06:44:05 +00:00
This repo is archived. You cannot comment on pull requests.
No reviewers
No Milestone
No project
No Assignees
2 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: lunny/gitea#3638
No description provided.