Add oauth providers via cli #4591

Merged
lunny merged 19 commits from auth-cli into master 2018-09-12 14:46:03 +00:00
Contributor
Related to https://github.com/go-gitea/gitea/issues/183#issuecomment-261824704 cc: @lunny TODO: - [x] Documentation
codecov-io commented 2018-08-01 19:00:34 +00:00 (Migrated from github.com)

Codecov Report

Merging #4591 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4591      +/-   ##
==========================================
- Coverage   37.39%   37.38%   -0.01%     
==========================================
  Files         305      305              
  Lines       45211    45211              
==========================================
- Hits        16905    16903       -2     
- Misses      25863    25864       +1     
- Partials     2443     2444       +1
Impacted Files Coverage Δ
modules/process/manager.go 76.81% <0%> (-4.35%) ⬇️
models/repo_list.go 56.37% <0%> (-1.35%) ⬇️
models/repo_indexer.go 50.84% <0%> (+1.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e3e59f...ba72d28. Read the comment docs.

# [Codecov](https://codecov.io/gh/go-gitea/gitea/pull/4591?src=pr&el=h1) Report > Merging [#4591](https://codecov.io/gh/go-gitea/gitea/pull/4591?src=pr&el=desc) into [master](https://codecov.io/gh/go-gitea/gitea/commit/8e3e59fdb8dffe23a04f1a2bef308d96a50961a6?src=pr&el=desc) will **decrease** coverage by `<.01%`. > The diff coverage is `n/a`. [![Impacted file tree graph](https://codecov.io/gh/go-gitea/gitea/pull/4591/graphs/tree.svg?width=650&token=t1G57YGbPy&height=150&src=pr)](https://codecov.io/gh/go-gitea/gitea/pull/4591?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #4591 +/- ## ========================================== - Coverage 37.39% 37.38% -0.01% ========================================== Files 305 305 Lines 45211 45211 ========================================== - Hits 16905 16903 -2 - Misses 25863 25864 +1 - Partials 2443 2444 +1 ``` | [Impacted Files](https://codecov.io/gh/go-gitea/gitea/pull/4591?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [modules/process/manager.go](https://codecov.io/gh/go-gitea/gitea/pull/4591/diff?src=pr&el=tree#diff-bW9kdWxlcy9wcm9jZXNzL21hbmFnZXIuZ28=) | `76.81% <0%> (-4.35%)` | :arrow_down: | | [models/repo\_list.go](https://codecov.io/gh/go-gitea/gitea/pull/4591/diff?src=pr&el=tree#diff-bW9kZWxzL3JlcG9fbGlzdC5nbw==) | `56.37% <0%> (-1.35%)` | :arrow_down: | | [models/repo\_indexer.go](https://codecov.io/gh/go-gitea/gitea/pull/4591/diff?src=pr&el=tree#diff-bW9kZWxzL3JlcG9faW5kZXhlci5nbw==) | `50.84% <0%> (+1.27%)` | :arrow_up: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/go-gitea/gitea/pull/4591?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/go-gitea/gitea/pull/4591?src=pr&el=footer). Last update [8e3e59f...ba72d28](https://codecov.io/gh/go-gitea/gitea/pull/4591?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

@techknowlogick but maybe you can consider add, delete, update subcommands?

@techknowlogick but maybe you can consider `add`, `delete`, `update` subcommands?
adelowo reviewed 2018-08-02 11:07:32 +00:00
Contributor

Shouldn't this be Use a custom Authorization URL ?

Shouldn't this be `Use a custom Authorization URL` ?
techknowlogick reviewed 2018-08-23 20:19:24 +00:00
Author
Contributor

Thanks. updated.

Thanks. updated.
Author
Contributor

@lunny I've added delete, update and list commands.

@lunny I've added `delete`, `update` and `list` commands.
lafriks (Migrated from github.com) reviewed 2018-08-24 17:52:51 +00:00
lafriks (Migrated from github.com) commented 2018-08-24 17:52:51 +00:00

Maybe this flag array could be moved out to array so that it could be reused in both add and update?

Maybe this flag array could be moved out to array so that it could be reused in both add and update?
techknowlogick reviewed 2018-08-24 21:16:44 +00:00
Author
Contributor

thanks @lafriks updated.

thanks @lafriks updated.
Author
Contributor

@lafriks changes made. Please review.

@lafriks changes made. Please review.
lafriks (Migrated from github.com) reviewed 2018-09-09 23:17:44 +00:00
lafriks (Migrated from github.com) commented 2018-09-09 23:17:44 +00:00

You could insert it id in this position only for add action

You could insert it id in this position only for add action
techknowlogick reviewed 2018-09-10 17:43:51 +00:00
Author
Contributor

updated

updated
lafriks (Migrated from github.com) reviewed 2018-09-11 13:57:26 +00:00
lafriks (Migrated from github.com) commented 2018-09-11 13:57:26 +00:00

maybe append(oauthCLIFlags[:1], append([]cli.Flag{idFlag}, oauthCLIFlags[1:]...)...)? To have better order :)

maybe `append(oauthCLIFlags[:1], append([]cli.Flag{idFlag}, oauthCLIFlags[1:]...)...)`? To have better order :)
lafriks (Migrated from github.com) approved these changes 2018-09-12 04:52:55 +00:00
Bwko (Migrated from github.com) approved these changes 2018-09-12 13:45:54 +00:00
This repo is archived. You cannot comment on pull requests.
No reviewers
No Milestone
No project
No Assignees
3 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: lunny/gitea#4591
No description provided.