Add whitespace handling to PR-comparsion #4683

techknowlogick · 2018-08-13T00:37:12Z

nemoinho commented

2018-08-13 00:37:12 +00:00

(Migrated from github.com)

In a PR we have to keep an eye on a lot of different things. But sometimes the bare code is the key-thing we want to care about and just don't want to care about fixed indention on some places. Especially if we follow the pathfinder rule we face a lot of these situations because these changes don't break the code in many languages but improve the readability a lot.

So this change introduce a fine graned button to adjust the way how the reviewer want to see whitespace-changes within the code.

The possibilities reflect the possibilities from git itself except of the --ignore-blank-lines flag because that one is also handled by -b and is really rare.

This solves at least partly #716

In a PR we have to keep an eye on a lot of different things. But sometimes the bare code is the key-thing we want to care about and just don't want to care about fixed indention on some places. Especially if we follow the pathfinder rule we face a lot of these situations because these changes don't break the code in many languages but improve the readability a lot. So this change introduce a fine graned button to adjust the way how the reviewer want to see whitespace-changes within the code. The possibilities reflect the possibilities from git itself except of the `--ignore-blank-lines` flag because that one is also handled by `-b` and is really rare. This solves at least partly #716

techknowlogick reviewed 2018-08-13 00:38:56 +00:00

options/locale/locale_de-DE.ini

techknowlogick commented

2018-08-13 00:38:56 +00:00

Thank you for contributing these translations, translations need to be provided by crowdin: https://crowdin.com/project/gitea

This is feedback about this specific file not a review of the entire PR

Thank you for contributing these translations, translations need to be provided by crowdin: https://crowdin.com/project/gitea This is feedback about this specific file not a review of the entire PR

codecov-io commented

2018-08-13 13:08:58 +00:00

(Migrated from github.com)

Codecov Report

Merging #4683 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #4683      +/-   ##
==========================================
- Coverage   20.64%   20.63%   -0.01%     
==========================================
  Files         166      166              
  Lines       32295    32314      +19     
==========================================
+ Hits         6666     6669       +3     
- Misses      24648    24665      +17     
+ Partials      981      980       -1

Impacted Files	Coverage Δ
models/git_diff.go	`27.76% <0%> (-0.28%)`	⬇️
routers/repo/middlewares.go	`0% <0%> (ø)`	⬆️
routers/repo/pull.go	`0% <0%> (ø)`	⬆️
modules/process/manager.go	`73.91% <0%> (+4.34%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03e558c...3127f2e. Read the comment docs.

# [Codecov](https://codecov.io/gh/go-gitea/gitea/pull/4683?src=pr&el=h1) Report > Merging [#4683](https://codecov.io/gh/go-gitea/gitea/pull/4683?src=pr&el=desc) into [master](https://codecov.io/gh/go-gitea/gitea/commit/03e558c29b55c522c52608065d2b688f8a9a4bc3?src=pr&el=desc) will **decrease** coverage by `<.01%`. > The diff coverage is `0%`. [![Impacted file tree graph](https://codecov.io/gh/go-gitea/gitea/pull/4683/graphs/tree.svg?width=650&height=150&src=pr&token=t1G57YGbPy)](https://codecov.io/gh/go-gitea/gitea/pull/4683?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #4683 +/- ## ========================================== - Coverage 20.64% 20.63% -0.01% ========================================== Files 166 166 Lines 32295 32314 +19 ========================================== + Hits 6666 6669 +3 - Misses 24648 24665 +17 + Partials 981 980 -1 ``` | [Impacted Files](https://codecov.io/gh/go-gitea/gitea/pull/4683?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [models/git\_diff.go](https://codecov.io/gh/go-gitea/gitea/pull/4683/diff?src=pr&el=tree#diff-bW9kZWxzL2dpdF9kaWZmLmdv) | `27.76% <0%> (-0.28%)` | :arrow_down: | | [routers/repo/middlewares.go](https://codecov.io/gh/go-gitea/gitea/pull/4683/diff?src=pr&el=tree#diff-cm91dGVycy9yZXBvL21pZGRsZXdhcmVzLmdv) | `0% <0%> (ø)` | :arrow_up: | | [routers/repo/pull.go](https://codecov.io/gh/go-gitea/gitea/pull/4683/diff?src=pr&el=tree#diff-cm91dGVycy9yZXBvL3B1bGwuZ28=) | `0% <0%> (ø)` | :arrow_up: | | [modules/process/manager.go](https://codecov.io/gh/go-gitea/gitea/pull/4683/diff?src=pr&el=tree#diff-bW9kdWxlcy9wcm9jZXNzL21hbmFnZXIuZ28=) | `73.91% <0%> (+4.34%)` | :arrow_up: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/go-gitea/gitea/pull/4683?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/go-gitea/gitea/pull/4683?src=pr&el=footer). Last update [03e558c...3127f2e](https://codecov.io/gh/go-gitea/gitea/pull/4683?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

lafriks (Migrated from github.com) approved these changes 2018-08-13 18:43:03 +00:00

lafriks (Migrated from github.com) left a comment

Thanks and great work! I hope you don't mind for some minor changes I did

nemoinho commented

2018-08-14 17:36:26 +00:00

(Migrated from github.com)

Thanks for the help, these changes are good and improve the code!
The tip where the translations are handled really helps a lot and I not even knew that platform.

Thanks for the help, these changes are good and improve the code! The tip where the translations are handled really helps a lot and I not even knew that platform.

techknowlogick approved these changes 2018-08-14 17:42:02 +00:00

This repo is archived. You cannot comment on pull requests.

No reviewers

lafriks