refactor: replace lint to revive #5422

appleboy · 2018-11-28T04:07:21Z

appleboy commented

2018-11-28 04:07:21 +00:00

lint time

$ time make lint
real    0m7.953s
user    0m5.928s
sys     0m2.129s

revive time

$ time make revive
revive -config config.toml -exclude=./vendor/... ./... || exit 1

real    0m5.179s
user    0m8.248s
sys     0m1.785s

## lint time ``` $ time make lint real 0m7.953s user 0m5.928s sys 0m2.129s ``` ## [revive](https://github.com/mgechev/revive) time ``` $ time make revive revive -config config.toml -exclude=./vendor/... ./... || exit 1 real 0m5.179s user 0m8.248s sys 0m1.785s ```

codecov-io commented

2018-11-28 04:16:17 +00:00

(Migrated from github.com)

Codecov Report

Merging #5422 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #5422   +/-   ##
=======================================
  Coverage   37.57%   37.57%           
=======================================
  Files         317      317           
  Lines       46824    46824           
=======================================
  Hits        17593    17593           
  Misses      26732    26732           
  Partials     2499     2499

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d707fe...8f2247d. Read the comment docs.

# [Codecov](https://codecov.io/gh/go-gitea/gitea/pull/5422?src=pr&el=h1) Report > Merging [#5422](https://codecov.io/gh/go-gitea/gitea/pull/5422?src=pr&el=desc) into [master](https://codecov.io/gh/go-gitea/gitea/commit/2d707fe5e663abb0be2127362c760446ce6cedab?src=pr&el=desc) will **not change** coverage. > The diff coverage is `n/a`. [![Impacted file tree graph](https://codecov.io/gh/go-gitea/gitea/pull/5422/graphs/tree.svg?width=650&token=t1G57YGbPy&height=150&src=pr)](https://codecov.io/gh/go-gitea/gitea/pull/5422?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #5422 +/- ## ======================================= Coverage 37.57% 37.57% ======================================= Files 317 317 Lines 46824 46824 ======================================= Hits 17593 17593 Misses 26732 26732 Partials 2499 2499 ``` ------ [Continue to review full report at Codecov](https://codecov.io/gh/go-gitea/gitea/pull/5422?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/go-gitea/gitea/pull/5422?src=pr&el=footer). Last update [2d707fe...8f2247d](https://codecov.io/gh/go-gitea/gitea/pull/5422?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).