Fix nil pointer base branch bug #5555

Merged
jonasfranz merged 3 commits from bugfix/baserepo-nil into master 2018-12-17 17:35:22 +00:00
jonasfranz commented 2018-12-17 12:58:24 +00:00 (Migrated from github.com)
No description provided.
kolaente (Migrated from github.com) approved these changes 2018-12-17 13:08:25 +00:00
adelowo approved these changes 2018-12-17 13:35:08 +00:00
codecov-io commented 2018-12-17 14:17:56 +00:00 (Migrated from github.com)

Codecov Report

No coverage uploaded for pull request base (master@8730ee0). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #5555   +/-   ##
=========================================
  Coverage          ?   37.53%           
=========================================
  Files             ?      320           
  Lines             ?    47152           
  Branches          ?        0           
=========================================
  Hits              ?    17699           
  Misses            ?    26909           
  Partials          ?     2544
Impacted Files Coverage Δ
models/pull.go 50.72% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8730ee0...b3600cd. Read the comment docs.

# [Codecov](https://codecov.io/gh/go-gitea/gitea/pull/5555?src=pr&el=h1) Report > :exclamation: No coverage uploaded for pull request base (`master@8730ee0`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit). > The diff coverage is `0%`. [![Impacted file tree graph](https://codecov.io/gh/go-gitea/gitea/pull/5555/graphs/tree.svg?width=650&token=t1G57YGbPy&height=150&src=pr)](https://codecov.io/gh/go-gitea/gitea/pull/5555?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #5555 +/- ## ========================================= Coverage ? 37.53% ========================================= Files ? 320 Lines ? 47152 Branches ? 0 ========================================= Hits ? 17699 Misses ? 26909 Partials ? 2544 ``` | [Impacted Files](https://codecov.io/gh/go-gitea/gitea/pull/5555?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [models/pull.go](https://codecov.io/gh/go-gitea/gitea/pull/5555/diff?src=pr&el=tree#diff-bW9kZWxzL3B1bGwuZ28=) | `50.72% <0%> (ø)` | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/go-gitea/gitea/pull/5555?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/go-gitea/gitea/pull/5555?src=pr&el=footer). Last update [8730ee0...b3600cd](https://codecov.io/gh/go-gitea/gitea/pull/5555?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

Should this be back port to v1.6?

Should this be back port to v1.6?
lafriks commented 2018-12-19 07:45:12 +00:00 (Migrated from github.com)

Yes please backport to 1.6

Yes please backport to 1.6
This repo is archived. You cannot comment on pull requests.
No reviewers
No Milestone
No project
No Assignees
2 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: lunny/gitea#5555
No description provided.