Add bio field for user #6113

techknowlogick · 2019-02-19T07:54:04Z

techknowlogick commented

2019-02-19 07:54:04 +00:00

user with simple bio:

user with no bio:

user with xss attempt that was escaped:

Fix #4339 user with simple bio: ![user with simple bio](https://user-images.githubusercontent.com/164197/52998744-10e42480-33f2-11e9-8bd9-6a88d7eb8186.png) user with no bio: ![user with no bio](https://user-images.githubusercontent.com/164197/52998745-10e42480-33f2-11e9-9290-0d15035fb9ee.png) user with xss attempt that was escaped: ![user with xss attempt that was escaped](https://user-images.githubusercontent.com/164197/52998746-10e42480-33f2-11e9-9692-6edf461b9357.png)

🎉 4

adelowo approved these changes 2019-02-19 07:58:01 +00:00

codecov-io commented

2019-02-19 08:04:54 +00:00

(Migrated from github.com)

Codecov Report

Merging #6113 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #6113      +/-   ##
==========================================
- Coverage   38.88%   38.87%   -0.02%     
==========================================
  Files         364      365       +1     
  Lines       51215    51341     +126     
==========================================
+ Hits        19916    19959      +43     
- Misses      28432    28509      +77     
- Partials     2867     2873       +6

Impacted Files	Coverage Δ
models/user.go	`49.76% <ø> (ø)`	⬆️
modules/auth/user_form.go	`42.85% <ø> (ø)`	⬆️
routers/user/setting/profile.go	`40.81% <100%> (+0.4%)`	⬆️
models/webhook.go	`63.18% <0%> (-5.54%)`	⬇️
modules/context/api.go	`50.61% <0%> (-0.21%)`	⬇️
models/repo.go	`47.36% <0%> (-0.09%)`	⬇️
routers/repo/webhook.go	`1.73% <0%> (-0.05%)`	⬇️
routers/admin/hooks.go	`0% <0%> (ø)`
routers/routes/routes.go	`83.44% <0%> (+0.36%)`	⬆️
routers/repo/view.go	`42.07% <0%> (+0.99%)`	⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba2f6a4...d2368b0. Read the comment docs.

# [Codecov](https://codecov.io/gh/go-gitea/gitea/pull/6113?src=pr&el=h1) Report > Merging [#6113](https://codecov.io/gh/go-gitea/gitea/pull/6113?src=pr&el=desc) into [master](https://codecov.io/gh/go-gitea/gitea/commit/ba2f6a45c8ef44f74772456fc98c27faca058241?src=pr&el=desc) will **decrease** coverage by `0.01%`. > The diff coverage is `100%`. [![Impacted file tree graph](https://codecov.io/gh/go-gitea/gitea/pull/6113/graphs/tree.svg?width=650&token=t1G57YGbPy&height=150&src=pr)](https://codecov.io/gh/go-gitea/gitea/pull/6113?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #6113 +/- ## ========================================== - Coverage 38.88% 38.87% -0.02% ========================================== Files 364 365 +1 Lines 51215 51341 +126 ========================================== + Hits 19916 19959 +43 - Misses 28432 28509 +77 - Partials 2867 2873 +6 ``` | [Impacted Files](https://codecov.io/gh/go-gitea/gitea/pull/6113?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [models/user.go](https://codecov.io/gh/go-gitea/gitea/pull/6113/diff?src=pr&el=tree#diff-bW9kZWxzL3VzZXIuZ28=) | `49.76% <ø> (ø)` | :arrow_up: | | [modules/auth/user\_form.go](https://codecov.io/gh/go-gitea/gitea/pull/6113/diff?src=pr&el=tree#diff-bW9kdWxlcy9hdXRoL3VzZXJfZm9ybS5nbw==) | `42.85% <ø> (ø)` | :arrow_up: | | [routers/user/setting/profile.go](https://codecov.io/gh/go-gitea/gitea/pull/6113/diff?src=pr&el=tree#diff-cm91dGVycy91c2VyL3NldHRpbmcvcHJvZmlsZS5nbw==) | `40.81% <100%> (+0.4%)` | :arrow_up: | | [models/webhook.go](https://codecov.io/gh/go-gitea/gitea/pull/6113/diff?src=pr&el=tree#diff-bW9kZWxzL3dlYmhvb2suZ28=) | `63.18% <0%> (-5.54%)` | :arrow_down: | | [modules/context/api.go](https://codecov.io/gh/go-gitea/gitea/pull/6113/diff?src=pr&el=tree#diff-bW9kdWxlcy9jb250ZXh0L2FwaS5nbw==) | `50.61% <0%> (-0.21%)` | :arrow_down: | | [models/repo.go](https://codecov.io/gh/go-gitea/gitea/pull/6113/diff?src=pr&el=tree#diff-bW9kZWxzL3JlcG8uZ28=) | `47.36% <0%> (-0.09%)` | :arrow_down: | | [routers/repo/webhook.go](https://codecov.io/gh/go-gitea/gitea/pull/6113/diff?src=pr&el=tree#diff-cm91dGVycy9yZXBvL3dlYmhvb2suZ28=) | `1.73% <0%> (-0.05%)` | :arrow_down: | | [routers/admin/hooks.go](https://codecov.io/gh/go-gitea/gitea/pull/6113/diff?src=pr&el=tree#diff-cm91dGVycy9hZG1pbi9ob29rcy5nbw==) | `0% <0%> (ø)` | | | [routers/routes/routes.go](https://codecov.io/gh/go-gitea/gitea/pull/6113/diff?src=pr&el=tree#diff-cm91dGVycy9yb3V0ZXMvcm91dGVzLmdv) | `83.44% <0%> (+0.36%)` | :arrow_up: | | [routers/repo/view.go](https://codecov.io/gh/go-gitea/gitea/pull/6113/diff?src=pr&el=tree#diff-cm91dGVycy9yZXBvL3ZpZXcuZ28=) | `42.07% <0%> (+0.99%)` | :arrow_up: | | ... and [1 more](https://codecov.io/gh/go-gitea/gitea/pull/6113/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/go-gitea/gitea/pull/6113?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/go-gitea/gitea/pull/6113?src=pr&el=footer). Last update [ba2f6a4...d2368b0](https://codecov.io/gh/go-gitea/gitea/pull/6113?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

zeripath commented

2019-02-19 08:11:44 +00:00

I think LDAP also has a user description attribute - although I'm not sure how many installs use it.