Fix v85.go #6851

zeripath · 2019-05-05T13:07:48Z

zeripath commented

2019-05-05 13:07:48 +00:00

In trying to create migration tests for MSSQL I've noticed that the v85 sets the UNIQUE constraint too early.

This PR fixes this by asserting the creation of the UNIQUE index later.

Signed-off-by: Andrew Thornton art27@cantab.net

In trying to create migration tests for MSSQL I've noticed that the v85 sets the UNIQUE constraint too early. This PR fixes this by asserting the creation of the UNIQUE index later. Signed-off-by: Andrew Thornton <art27@cantab.net>

adelowo approved these changes 2019-05-05 13:26:08 +00:00

codecov-io commented

2019-05-05 13:37:43 +00:00

(Migrated from github.com)

Codecov Report

Merging #6851 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #6851      +/-   ##
==========================================
- Coverage   41.18%   41.17%   -0.02%     
==========================================
  Files         423      423              
  Lines       58399    58416      +17     
==========================================
- Hits        24052    24051       -1     
- Misses      31169    31185      +16     
- Partials     3178     3180       +2

Impacted Files	Coverage Δ
models/migrations/v85.go	`0% <0%> (ø)`	⬆️
modules/log/file.go	`75.52% <0%> (-2.1%)`	⬇️
models/unit.go	`67.56% <0%> (+5.4%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d27bf72...d9d5a27. Read the comment docs.

# [Codecov](https://codecov.io/gh/go-gitea/gitea/pull/6851?src=pr&el=h1) Report > Merging [#6851](https://codecov.io/gh/go-gitea/gitea/pull/6851?src=pr&el=desc) into [master](https://codecov.io/gh/go-gitea/gitea/commit/d27bf72530864c0b81b135d3200d65722e82a6f3?src=pr&el=desc) will **decrease** coverage by `0.01%`. > The diff coverage is `0%`. [![Impacted file tree graph](https://codecov.io/gh/go-gitea/gitea/pull/6851/graphs/tree.svg?width=650&token=t1G57YGbPy&height=150&src=pr)](https://codecov.io/gh/go-gitea/gitea/pull/6851?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #6851 +/- ## ========================================== - Coverage 41.18% 41.17% -0.02% ========================================== Files 423 423 Lines 58399 58416 +17 ========================================== - Hits 24052 24051 -1 - Misses 31169 31185 +16 - Partials 3178 3180 +2 ``` | [Impacted Files](https://codecov.io/gh/go-gitea/gitea/pull/6851?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [models/migrations/v85.go](https://codecov.io/gh/go-gitea/gitea/pull/6851/diff?src=pr&el=tree#diff-bW9kZWxzL21pZ3JhdGlvbnMvdjg1Lmdv) | `0% <0%> (ø)` | :arrow_up: | | [modules/log/file.go](https://codecov.io/gh/go-gitea/gitea/pull/6851/diff?src=pr&el=tree#diff-bW9kdWxlcy9sb2cvZmlsZS5nbw==) | `75.52% <0%> (-2.1%)` | :arrow_down: | | [models/unit.go](https://codecov.io/gh/go-gitea/gitea/pull/6851/diff?src=pr&el=tree#diff-bW9kZWxzL3VuaXQuZ28=) | `67.56% <0%> (+5.4%)` | :arrow_up: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/go-gitea/gitea/pull/6851?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/go-gitea/gitea/pull/6851?src=pr&el=footer). Last update [d27bf72...d9d5a27](https://codecov.io/gh/go-gitea/gitea/pull/6851?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).