feat: highlight issue references with : #8101

techknowlogick · 2019-09-05T13:13:19Z

grinat commented

2019-09-05 13:13:19 +00:00

(Migrated from github.com)

I changed regex pattern for highlight external bug tracker issue which contains :
e.g.: "feat: TCP-100: my commit msg"
e.g.: "feat: #100: my commit msg"

before:

after:

I changed regex pattern for highlight external bug tracker issue which contains : e.g.: "feat: TCP-100: my commit msg" e.g.: "feat: #100: my commit msg" before: ![c5f18495af](https://user-images.githubusercontent.com/16123366/64341432-ff124980-cff0-11e9-9f3c-4cd1549b92c9.png) after: ![e568452f0a](https://user-images.githubusercontent.com/16123366/64341457-0e919280-cff1-11e9-9b84-c7f2b57cdcca.png)

codecov-io commented

2019-09-05 13:32:36 +00:00

(Migrated from github.com)

Codecov Report

❗ No coverage uploaded for pull request base (master@85f5654). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #8101   +/-   ##
=========================================
  Coverage          ?   41.78%           
=========================================
  Files             ?      481           
  Lines             ?    64425           
  Branches          ?        0           
=========================================
  Hits              ?    26922           
  Misses            ?    34035           
  Partials          ?     3468

Impacted Files	Coverage Δ
modules/markup/html.go	`81.51% <ø> (ø)`
models/action.go	`54.25% <ø> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85f5654...64ed52a. Read the comment docs.

# [Codecov](https://codecov.io/gh/go-gitea/gitea/pull/8101?src=pr&el=h1) Report > :exclamation: No coverage uploaded for pull request base (`master@85f5654`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit). > The diff coverage is `n/a`. [![Impacted file tree graph](https://codecov.io/gh/go-gitea/gitea/pull/8101/graphs/tree.svg?width=650&token=t1G57YGbPy&height=150&src=pr)](https://codecov.io/gh/go-gitea/gitea/pull/8101?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #8101 +/- ## ========================================= Coverage ? 41.78% ========================================= Files ? 481 Lines ? 64425 Branches ? 0 ========================================= Hits ? 26922 Misses ? 34035 Partials ? 3468 ``` | [Impacted Files](https://codecov.io/gh/go-gitea/gitea/pull/8101?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [modules/markup/html.go](https://codecov.io/gh/go-gitea/gitea/pull/8101/diff?src=pr&el=tree#diff-bW9kdWxlcy9tYXJrdXAvaHRtbC5nbw==) | `81.51% <ø> (ø)` | | | [models/action.go](https://codecov.io/gh/go-gitea/gitea/pull/8101/diff?src=pr&el=tree#diff-bW9kZWxzL2FjdGlvbi5nbw==) | `54.25% <ø> (ø)` | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/go-gitea/gitea/pull/8101?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/go-gitea/gitea/pull/8101?src=pr&el=footer). Last update [85f5654...64ed52a](https://codecov.io/gh/go-gitea/gitea/pull/8101?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

lafriks (Migrated from github.com) approved these changes 2019-09-05 14:07:46 +00:00

mrsdizzie (Migrated from github.com) requested changes 2019-09-05 15:24:36 +00:00

mrsdizzie (Migrated from github.com) left a comment

Thank you for the PR!

Can you add a few quick test cases to the existing set so this change won't get lost in the future:

If not familiar probably in these two spots:

85f56546c4/modules/markup/html_internal_test.go (L348)

85f56546c4/modules/markup/html_internal_test.go (L234)

and maybe

85f56546c4/modules/markup/html_internal_test.go (L104)

So just add an example or two that use a :

Also can you update the regex here:

85f56546c4/models/action.go (L68)

Just so it is consistent for now

Thank you for the PR! Can you add a few quick test cases to the existing set so this change won't get lost in the future: If not familiar probably in these two spots: https://github.com/go-gitea/gitea/blob/85f56546c4259ed9c11d31973344228ad667084e/modules/markup/html_internal_test.go#L348 https://github.com/go-gitea/gitea/blob/85f56546c4259ed9c11d31973344228ad667084e/modules/markup/html_internal_test.go#L234 and maybe https://github.com/go-gitea/gitea/blob/85f56546c4259ed9c11d31973344228ad667084e/modules/markup/html_internal_test.go#L104 So just add an example or two that use a ```:``` Also can you update the regex here: https://github.com/go-gitea/gitea/blob/85f56546c4259ed9c11d31973344228ad667084e/models/action.go#L68 Just so it is consistent for now

mrsdizzie (Migrated from github.com) approved these changes 2019-09-05 16:37:06 +00:00

techknowlogick commented

2019-09-06 00:39:47 +00:00

ping LG-TM bot