Fix bug on pull requests when transfer head repository #8564

lunny · 2019-10-17T16:07:50Z

lunny commented

2019-10-17 16:07:50 +00:00

Fix #8563

guillep2k (Migrated from github.com) approved these changes 2019-10-17 16:19:30 +00:00

guillep2k (Migrated from github.com) left a comment

Code looks good to me. I'm still not sure what was the actual use of that column.

models/pull.go

guillep2k (Migrated from github.com) commented

2019-10-17 16:13:37 +00:00

We could add

		pr.HeadRepo = &repo
		if pr.HeadRepoID == pr.BaseRepoID {
			pr.BaseRepo = pr.HeadRepo
		}

We could add ```suggestion pr.HeadRepo = &repo if pr.HeadRepoID == pr.BaseRepoID { pr.BaseRepo = pr.HeadRepo } ```

routers/repo/pull.go

guillep2k (Migrated from github.com) commented

2019-10-17 16:18:15 +00:00

pull.HeadRepo.RepoPath() ?

`pull.HeadRepo.RepoPath()` ?

lunny reviewed 2019-10-18 03:18:54 +00:00

models/pull.go

lunny commented

2019-10-18 03:18:54 +00:00

Done. Not here but in LoadBaseRepo.

Done. Not here but in `LoadBaseRepo`.

lunny reviewed 2019-10-18 03:19:55 +00:00

routers/repo/pull.go

lunny commented

2019-10-18 03:19:55 +00:00

@guillep2k No. pull.HeadRepo.RepoPath() will return repo's location on file system. But here we need a headTarget.

@guillep2k No. `pull.HeadRepo.RepoPath()` will return repo's location on file system. But here we need a `headTarget`.

lafriks (Migrated from github.com) approved these changes 2019-10-18 10:30:01 +00:00

This repo is archived. You cannot comment on pull requests.

No reviewers

guillep2k

lafriks

No Label

hacktoberfest-accepted

kind/upstream-related

status/needs-feedback

No Milestone

No project

No Assignees

1 Participants

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: lunny/gitea#8564