Fix the click behavior for <tr> and <td> with [data-href] #17388

wxiaoguang · 2021-10-21T14:58:37Z

wxiaoguang commented

2021-10-21 14:58:37 +00:00

There was JS code making table <tr> and <td> elements clickable like a link, but the behavior is not the same as modern browsers.

This PR makes the click behavior for <tr> and <td> with [data-href] the same as modern browsers: if a user clicks it with key Ctrl(Windows) or Meta(macOS) pressed, the link will be opened in a new window/tab.

Also, if there is a <a> inside the <td>, we should not process the click event because the <a> already handles it.

There was JS code making table `<tr>` and `<td>` elements clickable like a link, but the behavior is not the same as modern browsers. This PR makes the click behavior for `<tr>` and `<td>` with `[data-href]` the same as modern browsers: if a user clicks it with key Ctrl(Windows) or Meta(macOS) pressed, the link will be opened in a new window/tab. Also, if there is a `<a>` inside the `<td>`, we should not process the click event because the `<a>` already handles it.