Prevent NPE if pushes/gets occur after the db is already closed #6

zeripath · 2022-07-28T20:53:34Z

zeripath commented

2022-07-28 20:53:34 +00:00

Due to the nil-ing out of the .db fields when Close is called any
further calls to the queue/set functions will result in an NPE.

This PR protects against this.

Signed-off-by: Andrew Thornton art27@cantab.net

Due to the nil-ing out of the `.db` fields when `Close` is called any further calls to the queue/set functions will result in an NPE. This PR protects against this. Signed-off-by: Andrew Thornton <art27@cantab.net>

zeripath added 1 commit 2022-07-28 20:53:35 +00:00

Prevent NPE if pushes/gets occur after the db is already closed

Due to the nil-ing out of the `.db` fields when `Close` is called any
further calls to the queue/set functions will result in an NPE.

This PR protects against this.

Signed-off-by: Andrew Thornton <art27@cantab.net>

continuous-integration/drone/pr Build is passing

Details

e7efcd331d

lunny reviewed 2022-07-29 01:58:47 +00:00

queue.go

						
				@ -301,3 +321,3 @@

					defer queue.highLock.Unlock()

					if !queue.closeUnderlyingDB {

					if !queue.closeUnderlyingDB || queue.db == nil {

lunny commented

2022-07-29 01:58:15 +00:00

Is this really necessary?

wxiaoguang commented

2022-07-29 02:12:03 +00:00

First-time contributor

IMO it's necessary. closeUnderlyingDB can be true or false. But the code below shouldn't access nil db.

lunny marked this conversation as resolved

uniquequeue.go

						
				@ -184,3 +184,3 @@

					queue.set.lock.Lock()

					defer queue.set.lock.Unlock()

					if !queue.closeUnderlyingDB {

					if !queue.closeUnderlyingDB || queue.db == nil {