Remove the init panic #1

We could actually get rid of the whole init block and require that anyone who needs Root set just sets it themselves. AFAICS we don't even use Root in Gitea.

👍 2

techknowlogick commented

2019-07-31 21:21:05 +00:00

@zeripath ok. updated with removed init func.

zeripath commented

2019-07-31 21:42:24 +00:00

So the other thing that init did was set whether macaron is in dev mode or not.

Not sure what people feel about removing that - we do advertise it on the website.

It's not hard to just set it ourselves though. Just need to remember that we need it.

@techknowlogick did you check that removing this initialisation doesn't break stuff? Or just take my word for it?

So the other thing that init did was set whether macaron is in dev mode or not. Not sure what people feel about removing that - we do advertise it on the website. It's not hard to just set it ourselves though. Just need to remember that we need it. @techknowlogick did you check that removing this initialisation doesn't break stuff? Or just take my word for it?

techknowlogick added the

status/blocked

label 2019-07-31 23:17:40 +00:00

techknowlogick commented

2019-07-31 23:23:20 +00:00

@zeripath 100% took your word for it. I've set this as blocked as you are right I should check to make sure it doesn't break things.

I think maybe I'll put env var back in because it might be helpful for development if someone wants to re-compile templates each request (someone who isn't be because I just restart binary each time 😆 )

@zeripath 100% took your word for it. I've set this as blocked as you are right I should check to make sure it doesn't break things. I think maybe I'll put env var back in because it might be helpful for development if someone wants to re-compile templates each request (someone who isn't be because I just restart binary each time :laughing: )

zeripath commented

2020-01-04 21:03:40 +00:00

I've just restored the SetENV(...) call and pushed this up.

I think we could now merge this.

I've just restored the `SetENV(...)` call and pushed this up. I think we could now merge this.

zeripath approved these changes 2020-01-04 21:04:11 +00:00

Dismissed

zeripath commented

2020-01-04 21:17:23 +00:00

I've also updated the unknwon links.

6543 reviewed 2020-01-04 21:44:24 +00:00

Dismissed

macaron.go

						
				@ -312,4 +311,1 @@

					setENV(os.Getenv("MACARON_ENV"))

					var err error

					Root, err = os.Getwd()

6543 commented

2020-01-04 21:44:24 +00:00

First-time contributor

@techknowlogick why didn't add you Root, GetwdErr = os.Getwd() as in https://github.com/go-macaron/macaron/pull/178?

@techknowlogick why didn't add you `Root, GetwdErr = os.Getwd()` as in https://github.com/go-macaron/macaron/pull/178?

zeripath commented

2020-01-04 22:23:48 +00:00

Because we don't use macaron.Root so the code is unnecessary

6543 commented

2020-01-04 22:30:56 +00:00

First-time contributor

just thinking of not to derive to far from original ... so we are able to port PR from and to our fork ...

6543 approved these changes 2020-01-04 22:30:02 +00:00

Dismissed

techknowlogick removed the

status/blocked

label 2020-01-05 02:31:25 +00:00

techknowlogick referenced this issue from a commit

2020-01-05 02:31:44 +00:00

Remove the init panic (#1) Merge branch 'master' into remove-init-panic Update from Unknwon to unknwon Restore setENV MACARON_ENV Use github.com/unknwon/com (#10) fix wrong depend (#7) use gitea.com/macaron/inject (#4) Update 'macaron.go' remove init func Merge remote-tracking branch 'origin/master' into remove-init-panic Remove the init panic Signed-off-by: Andrew Thornton <art27@cantab.net> Signed-off-by: Matti R <matti@mdranta.net> Co-authored-by: Andrew Thornton <art27@cantab.net> Co-authored-by: tamalsaha <tamalsaha@noreply@gitea.io> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: Matti R <matti@mdranta.net> Reviewed-by: Andrew Thornton <art27@cantab.net> Reviewed-by: 6543 <6543@noreply.gitea.io>

techknowlogick closed this pull request

2020-01-05 02:31:45 +00:00

techknowlogick deleted branch remove-init-panic

2020-01-05 02:31:54 +00:00

This repo is archived. You cannot comment on pull requests.

No reviewers

No Milestone

No Assignees

4 Participants

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: macaron/macaron#1