Release new version? #6

New Issue

tamalsaha · 2019-08-03T16:53:50Z

tamalsaha commented

2019-08-03 16:53:50 +00:00

Should a new version, say v1.4.0 be released with updated module path and any fixes?

I think then it should be vendored in all the other repos.

Should a new version, say v1.4.0 be released with updated module path and any fixes? I think then it should be vendored in all the other repos.

tamalsaha commented

2019-08-03 16:54:30 +00:00

cc: @lunny @zeripath @techknowlogick

lunny commented

2019-08-03 17:25:22 +00:00

I think we have to wait macaron/inject#1. There is still a wrong dependent package, see https://gitea.com/macaron/macaron/src/branch/master/go.mod#L8 .

I think we have to wait https://gitea.com/macaron/inject/pulls/1. There is still a wrong dependent package, see https://gitea.com/macaron/macaron/src/branch/master/go.mod#L8 .

lunny commented

2019-08-03 17:34:36 +00:00

depend on #7

depend on https://gitea.com/macaron/macaron/pulls/7

lunny commented

2019-08-03 17:40:45 +00:00

Since #7 merged, we can tag the version.

tamalsaha commented

2019-08-03 17:50:23 +00:00

In the same vein, should a v0.1.0 release be cut for all the other repos? I think it will make it far more readable in a go.mod file.

In the same vein, should a `v0.1.0` release be cut for all the other repos? I think it will make it far more readable in a go.mod file.

lunny commented

2019-08-04 00:36:27 +00:00

And maybe we should wait #1 and #5

👍 1

techknowlogick commented

2020-01-05 02:33:20 +00:00

I've just tagged 1.4.0, and so I will close this.

techknowlogick closed this issue

2020-01-05 02:33:21 +00:00

This repo is archived. You cannot comment on issues.

No Milestone

No Assignees

3 Participants

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: macaron/macaron#6