github.com/Unknwon/com or github.com/unknwon/com #8

Closed
opened 2019-08-04 21:55:49 +00:00 by tamalsaha · 13 comments
Contributor

It seems that this repo just changed their go.mod file to use small U. https://github.com/unknwon/com/commits/master/go.mod

This will need a global search and replace. What do you want to do?

For me, it was breaking build:

go: github.com/Unknwon/com@v0.0.0-20190804042917-757f69c95f3e: parsing go.mod: unexpected module path "github.com/unknwon/com"
It seems that this repo just changed their go.mod file to use `small U`. https://github.com/unknwon/com/commits/master/go.mod This will need a global search and replace. What do you want to do? For me, it was breaking build: - https://gitea.com/macaron/macaron/pulls/5#issuecomment-24265 - https://drone.gitea.com/macaron/macaron/23/1/2 ``` go: github.com/Unknwon/com@v0.0.0-20190804042917-757f69c95f3e: parsing go.mod: unexpected module path "github.com/unknwon/com" ```
Contributor

I would like use an extra package to instead com because I don't like the package name. I wrote one on https://gitea.com/lunny/path, it should satisfy most requirements.

I would like use an extra package to instead com because I don't like the package name. I wrote one on https://gitea.com/lunny/path, it should satisfy most requirements.
Author
Contributor

I have not checked all the ways this com library is used but if that can be replaced with lunny/path that sounds ok to me.

In general, I do worry about the scope of this forking project. Hopefully this is the last library that needs to be forked.

I have not checked all the ways this `com` library is used but if that can be replaced with lunny/path that sounds ok to me. In general, I do worry about the scope of this forking project. Hopefully this is the last library that needs to be forked.
Contributor

@tamalsaha it maybe not the last one because gitea depends on so many external libraries which will not maintained actively. But we should always depend on well-maintained package.

For a long target, we should use gin/chi to instead macaron. So my idea may not be useful.

@tamalsaha it maybe not the last one because gitea depends on so many external libraries which will not maintained actively. But we should always depend on well-maintained package. For a long target, we should use gin/chi to instead macaron. So my idea may not be useful.
Author
Contributor

I think it might be easier to fork any library that is coming from Unknwon for this round and use the forked version. I think it is clear that he does not want to accept contribution from anyone or maintain his libraries. Later we can evaluate what else to replace.

Personally I am not convinced that the effort needed to change the underlying framework is worth the effort. I can be persuaded if there is a list of use-cases that shows that the underlying framework is the limiting factor.

Maintaining open source code is a lot of work that you know as well as anyone. But if libraries are mostly doing what they are supposed to do, there may be not much activity. So, it will be useful to see a list of dependencies which you see needs forking or replaced.

I think it might be easier to fork any library that is coming from Unknwon for this round and use the forked version. I think it is clear that he does not want to accept contribution from anyone or maintain his libraries. Later we can evaluate what else to replace. Personally I am not convinced that the effort needed to change the underlying framework is worth the effort. I can be persuaded if there is a list of use-cases that shows that the underlying framework is the limiting factor. Maintaining open source code is a lot of work that you know as well as anyone. But if libraries are mostly doing what they are supposed to do, there may be not much activity. So, it will be useful to see a list of dependencies which you see needs forking or replaced.
Author
Contributor

To make it clear, I am proposing that github.com/unknwon/com be forked into gitea.com/macaron/com then used in gitea.com/macaron/macaron and gitea repo for now.

To make it clear, I am proposing that `github.com/unknwon/com` be forked into `gitea.com/macaron/com` then used in `gitea.com/macaron/macaron` and gitea repo for now.
Contributor

Why not just replace all github.com/Unknwon/com to github.com/unknwon/com?

Why not just replace all `github.com/Unknwon/com` to `github.com/unknwon/com`?
Author
Contributor

That also works. That's what upstream repo did: https://github.com/go-macaron/macaron/compare/v1.3.3...master

I was thinking that we could remove dependency on any repo from https://github.com/unknwon so that we can fix any bugs if needed in the fork.

That also works. That's what upstream repo did: https://github.com/go-macaron/macaron/compare/v1.3.3...master I was thinking that we could remove dependency on any repo from https://github.com/unknwon so that we can fix any bugs if needed in the fork.
Author
Contributor

@lunny , any thoughts on how to move forward on this one?

@lunny , any thoughts on how to move forward on this one?
Contributor

@tamalsaha Since we will remove com package, I think we can just simply rename it currently and won't maintain this package. :(

@tamalsaha Since we will remove `com` package, I think we can just simply rename it currently and won't maintain this package. :(
lunny added the
kind/proposal
label 2019-08-13 02:12:45 +00:00
Author
Contributor
@zeripath , @techknowlogick - it will be great if you can approve these prs. - https://gitea.com/macaron/cache/pulls/8 - https://gitea.com/macaron/i18n/pulls/3 - https://gitea.com/macaron/binding/pulls/3 - https://gitea.com/macaron/session/pulls/9 - https://gitea.com/macaron/toolbox/pulls/4
Author
Contributor

This is the last one macaron/captcha#6 . I needed the cache repo to be merged first. After this prs are merged, we should be able to update gitea.

This is the last one https://gitea.com/macaron/captcha/pulls/6 . I needed the cache repo to be merged first. After this prs are merged, we should be able to update gitea.
Author
Contributor

Sorry, one more macaron/csrf#7 . I missed this one.

Sorry, one more https://gitea.com/macaron/csrf/pulls/7 . I missed this one.
Author
Contributor

Thanks for approving all the prs. I have opened https://github.com/go-gitea/gitea/pull/7933 .

Thanks for approving all the prs. I have opened https://github.com/go-gitea/gitea/pull/7933 .
This repo is archived. You cannot comment on issues.
No description provided.