github.com/Unknwon/com or github.com/unknwon/com #8
Labels
No Label
kind/breaking
kind/bug
kind/deployment
kind/docs
kind/enhancement
kind/feature
kind/lint
kind/proposal
kind/question
kind/security
kind/testing
kind/translation
kind/ui
lgtm/done
lgtm/need
lgtm/need
priority/critical
priority/low
priority/maybe
priority/medium
refactor
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
status/blocked
status/needs-feedback
status/wip
No Milestone
No Assignees
2 Participants
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: macaron/macaron#8
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
It seems that this repo just changed their go.mod file to use
small U
. https://github.com/unknwon/com/commits/master/go.modThis will need a global search and replace. What do you want to do?
For me, it was breaking build:
I would like use an extra package to instead com because I don't like the package name. I wrote one on https://gitea.com/lunny/path, it should satisfy most requirements.
I have not checked all the ways this
com
library is used but if that can be replaced with lunny/path that sounds ok to me.In general, I do worry about the scope of this forking project. Hopefully this is the last library that needs to be forked.
@tamalsaha it maybe not the last one because gitea depends on so many external libraries which will not maintained actively. But we should always depend on well-maintained package.
For a long target, we should use gin/chi to instead macaron. So my idea may not be useful.
I think it might be easier to fork any library that is coming from Unknwon for this round and use the forked version. I think it is clear that he does not want to accept contribution from anyone or maintain his libraries. Later we can evaluate what else to replace.
Personally I am not convinced that the effort needed to change the underlying framework is worth the effort. I can be persuaded if there is a list of use-cases that shows that the underlying framework is the limiting factor.
Maintaining open source code is a lot of work that you know as well as anyone. But if libraries are mostly doing what they are supposed to do, there may be not much activity. So, it will be useful to see a list of dependencies which you see needs forking or replaced.
To make it clear, I am proposing that
github.com/unknwon/com
be forked intogitea.com/macaron/com
then used ingitea.com/macaron/macaron
and gitea repo for now.Why not just replace all
github.com/Unknwon/com
togithub.com/unknwon/com
?That also works. That's what upstream repo did: https://github.com/go-macaron/macaron/compare/v1.3.3...master
I was thinking that we could remove dependency on any repo from https://github.com/unknwon so that we can fix any bugs if needed in the fork.
@lunny , any thoughts on how to move forward on this one?
@tamalsaha Since we will remove
com
package, I think we can just simply rename it currently and won't maintain this package. :(@zeripath , @techknowlogick - it will be great if you can approve these prs.
This is the last one macaron/captcha#6 . I needed the cache repo to be merged first. After this prs are merged, we should be able to update gitea.
Sorry, one more macaron/csrf#7 . I missed this one.
Thanks for approving all the prs. I have opened https://github.com/go-gitea/gitea/pull/7933 .