Create functional option for ctx.SetCookie #14
No reviewers
Labels
No Label
kind/breaking
kind/bug
kind/deployment
kind/docs
kind/enhancement
kind/feature
kind/lint
kind/proposal
kind/question
kind/security
kind/testing
kind/translation
kind/ui
lgtm/done
lgtm/need
lgtm/need
priority/critical
priority/low
priority/maybe
priority/medium
refactor
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
status/blocked
status/needs-feedback
status/wip
No Milestone
No Assignees
4 Participants
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: macaron/macaron#14
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "zeripath/macaron:refactor-set-cookie"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Allowing
func(*http.Cookie)
to be passed into the SetCookie call will allow us to extend SetCookie to set the SameSite attribute easily.(This PR also does some slight cleanup to context.go fixing minor lint issues.)
@ -0,0 +1,79 @@
// Copyright 2020 The Macaron Authors
//
Could you also add Gitea as well?
done
@zeripath did you file a upstream pull?
or do we differ to mouch already?
Didn't file an upstream PR as we don't use it but can do if preferred.
@zeripath creating a pull upstream would be nice, so we do not divide to mouch from it - if it get merged ... is another question :D
c956201ffa
to3453d4d8a6