[Doc] [UI] Use Crowdin for Translation #96

6543 · 2019-10-04T14:07:57Z

6543 commented

2019-10-04 14:07:57 +00:00

Changes

README 75ac6ff113
CONTRIBUTING 9ef04b1287
About UI (atatchment)

# Changes * README https://gitea.com/6543/GitNex/commit/75ac6ff1137225a4ff67b122e31dab134029c6e3 * CONTRIBUTING https://gitea.com/6543/GitNex/commit/9ef04b1287e3cc2d5ffa42d3d4339e66b37febb6 * About UI (atatchment)

mmarif reviewed 2019-10-04 14:29:18 +00:00

Dismissed

CONTRIBUTING.md Outdated

mmarif commented

2019-10-04 14:29:18 +00:00

We use [Crowdin](https://crowdin.com/project/gitnex).

could be for better understanding.

We use [Crowdin](https://crowdin.com/project/gitnex) for translation. If your language is not listed, please request [here](https://gitea.com/mmarif/GitNex/issues) to add it to the project.

The rest are fine.

`We use [Crowdin](https://crowdin.com/project/gitnex).` could be for better understanding. `We use [Crowdin](https://crowdin.com/project/gitnex) for translation. If your language is not listed, please request [here](https://gitea.com/mmarif/GitNex/issues) to add it to the project.` The rest are fine.

6543 commented

2019-10-04 14:30:30 +00:00

about page

Screenshot_1570199421.png

146 KiB

6543 changed title from ~~[WIP] Use Crowdin for Translation [Doc]~~ to [Doc] Use Crowdin for Translation

2019-10-04 14:30:43 +00:00

6543 changed title from ~~[Doc] Use Crowdin for Translation~~ to [Doc] [UI] Use Crowdin for Translation

2019-10-04 14:30:52 +00:00

mmarif commented

2019-10-04 14:40:55 +00:00

This is awesome. I have added comment on contribution file to modify it little bit.

About UI looks nice.

This is awesome. I have added comment on contribution file to modify it little bit. About UI looks nice.

mmarif added the

Enhancement

label 2019-10-04 14:50:36 +00:00

mmarif added this to the 2.2.0 milestone 2019-10-04 14:51:07 +00:00

mmarif reviewed 2019-10-04 15:04:03 +00:00

Dismissed

app/src/main/java/org/mian/gitnex/fragments/AboutFragment.java Outdated

mmarif commented

2019-10-04 15:04:03 +00:00

Seems this is hard coded. Can you add this link to strings.xml with translatable set to false?

mmarif commented

2019-10-04 15:04:38 +00:00

Just one more comment to address, after that all good.

6543 reviewed 2019-10-04 15:18:23 +00:00

Dismissed

app/src/main/java/org/mian/gitnex/fragments/AboutFragment.java Outdated

6543 commented

2019-10-04 15:18:23 +00:00

i dont cnow how to access @string in java :(

mmarif reviewed 2019-10-04 15:32:59 +00:00

Dismissed

app/src/main/java/org/mian/gitnex/fragments/AboutFragment.java Outdated

mmarif commented

2019-10-04 15:32:59 +00:00

Add the following in strings.xml below appDesc string.

<string name="corwdinLink" translatable="false">https://crowdin.com/project/gitnex</string>

Change this line
intent.setData(Uri.parse("https://crowdin.com/project/gitnex"));
to
intent.setData(Uri.parse(getResources().getString(R.string.corwdinLink)));

Add the following in strings.xml below `appDesc` string. `<string name="corwdinLink" translatable="false">https://crowdin.com/project/gitnex</string>` Change this line ` intent.setData(Uri.parse("https://crowdin.com/project/gitnex"));` to `intent.setData(Uri.parse(getResources().getString(R.string.corwdinLink)));`

6543 commented

2019-10-04 15:45:48 +00:00

ok this is just fine! with each "comment" we all improve (app,knowlange,...)

👍 1

6543 commented

2019-10-04 15:48:38 +00:00

now the url is in the string.xml :) -> Android Studio resolve getResources().getString(R.string.StringID) to its value so i didnt noticed this until you told me so

now the url is in the string.xml :) -> Android Studio resolve `getResources().getString(R.string.StringID)` to its value so i didnt noticed this until you told me so

mmarif commented

2019-10-04 15:53:04 +00:00

Most of the strings(text, urls etc) are all in strings.xml file. Nothing is hard coded, which is sometime pain to change when hard coded.

getResources() and getString() depend on where you are like activity or fragment or other java file. Sometime you will need app context to access the resources(getApplicationContext() or getContext()).

I guess this PR is ready to merge?

Most of the strings(text, urls etc) are all in strings.xml file. Nothing is hard coded, which is sometime pain to change when hard coded. `getResources()` and `getString()` depend on where you are like activity or fragment or other java file. Sometime you will need app context to access the resources(`getApplicationContext()` or `getContext()`). I guess this PR is ready to merge?

6543 commented

2019-10-04 15:55:17 +00:00

it is 🚀

it is :rocket:

mmarif closed this pull request

2019-10-04 15:56:44 +00:00

mmarif closed this pull request

2019-10-04 15:56:44 +00:00

mmarif deleted branch translation-tool

2019-10-04 15:56:57 +00:00

This repo is archived. You cannot comment on pull requests.

No reviewers