Binding middleware for tango
You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

178 lines
5.2 KiB

// Copyright 2014 martini-contrib/binding Authors
// Copyright 2014 Unknwon
//
// Licensed under the Apache License, Version 2.0 (the "License"): you may
// not use this file except in compliance with the License. You may obtain
// a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
// WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
// License for the specific language governing permissions and limitations
// under the License.
package binding
import (
"bytes"
"fmt"
"mime/multipart"
"net/http"
"net/http/httptest"
"reflect"
"strconv"
"testing"
"gitea.com/lunny/tango"
. "github.com/smartystreets/goconvey/convey"
)
var multipartFormTestCases = []multipartFormTestCase{
{
description: "Happy multipart form path",
shouldSucceed: true,
inputAndExpected: BlogPost{Post: Post{Title: "Glorious Post Title"}, Id: 1, Author: Person{Name: "Matt Holt"}},
},
{
description: "FormValue called before req.MultipartReader(); see https://github.com/martini-contrib/csrf/issues/6",
shouldSucceed: true,
callFormValueBefore: true,
inputAndExpected: BlogPost{Post: Post{Title: "Glorious Post Title"}, Id: 1, Author: Person{Name: "Matt Holt"}},
},
{
description: "Empty payload",
shouldSucceed: false,
inputAndExpected: BlogPost{},
},
{
description: "Missing required field (Id)",
shouldSucceed: false,
inputAndExpected: BlogPost{Post: Post{Title: "Glorious Post Title"}, Author: Person{Name: "Matt Holt"}},
},
{
description: "Required embedded struct field not specified",
shouldSucceed: false,
inputAndExpected: BlogPost{Id: 1, Author: Person{Name: "Matt Holt"}},
},
{
description: "Required nested struct field not specified",
shouldSucceed: false,
inputAndExpected: BlogPost{Post: Post{Title: "Glorious Post Title"}, Id: 1},
},
{
description: "Multiple values",
shouldSucceed: true,
inputAndExpected: BlogPost{Post: Post{Title: "Glorious Post Title"}, Id: 1, Author: Person{Name: "Matt Holt"}, Ratings: []int{3, 5, 4}},
},
{
description: "Bad multipart encoding",
shouldSucceed: false,
malformEncoding: true,
},
}
func Test_MultipartForm(t *testing.T) {
Convey("Test multipart form", t, func() {
for _, testCase := range multipartFormTestCases {
performMultipartFormTest(t, testCase)
}
})
}
/*
var obj interface{}
var errors Errors
*/
type MultipartFormAction struct {
Binder
}
func (v MultipartFormAction) Post() error {
errors = v.Bind(obj)
if errors.Len() > 0 {
return fmt.Errorf("%+v", errors)
}
return nil
}
func performMultipartFormTest(t *testing.T, testCase multipartFormTestCase) {
httpRecorder := httptest.NewRecorder()
m := tango.Classic()
m.Use(Bind())
obj = &BlogPost{}
m.Post(testRoute, new(MultipartFormAction))
multipartPayload, mpWriter := makeMultipartPayload(testCase)
req, err := http.NewRequest("POST", testRoute, multipartPayload)
if err != nil {
panic(err)
}
req.Header.Add("Content-Type", mpWriter.FormDataContentType())
err = mpWriter.Close()
if err != nil {
panic(err)
}
if testCase.callFormValueBefore {
req.FormValue("foo")
}
m.ServeHTTP(httpRecorder, req)
switch httpRecorder.Code {
case http.StatusNotFound:
if testCase.shouldSucceed {
panic("Routing is messed up in test fixture (got 404): check methods and paths")
}
case http.StatusInternalServerError:
if testCase.shouldSucceed {
panic("Something bad happened on '" + testCase.description + "'")
}
}
if testCase.shouldSucceed && len(errors) > 0 {
So(len(errors), ShouldEqual, 0)
} else if !testCase.shouldSucceed && len(errors) == 0 {
So(len(errors), ShouldNotEqual, 0)
}
So(fmt.Sprintf("%+v", reflect.ValueOf(obj).Elem().Interface()), ShouldEqual, fmt.Sprintf("%+v", testCase.inputAndExpected))
}
// Writes the input from a test case into a buffer using the multipart writer.
func makeMultipartPayload(testCase multipartFormTestCase) (*bytes.Buffer, *multipart.Writer) {
body := &bytes.Buffer{}
writer := multipart.NewWriter(body)
if testCase.malformEncoding {
// TODO: Break the multipart form parser which is apparently impervious!!
// (Get it to return an error. Trying to get 100% test coverage.)
body.Write([]byte(`--` + writer.Boundary() + `\nContent-Disposition: form-data; name="foo"\n\n--` + writer.Boundary() + `--`))
return body, writer
} else {
writer.WriteField("title", testCase.inputAndExpected.Title)
writer.WriteField("content", testCase.inputAndExpected.Content)
writer.WriteField("id", strconv.Itoa(testCase.inputAndExpected.Id))
writer.WriteField("ignored", testCase.inputAndExpected.Ignored)
for _, value := range testCase.inputAndExpected.Ratings {
writer.WriteField("rating", strconv.Itoa(value))
}
writer.WriteField("name", testCase.inputAndExpected.Author.Name)
writer.WriteField("email", testCase.inputAndExpected.Author.Email)
return body, writer
}
}
type (
multipartFormTestCase struct {
description string
shouldSucceed bool
inputAndExpected BlogPost
malformEncoding bool
callFormValueBefore bool
}
)