Insert: sort column names #10

New Issue

lunny · 2018-04-25T15:52:26Z

lunny commented

2018-04-25 15:52:26 +00:00

Author: @fasterthanlime

These insert statements are generated with go-xorm/builder:

[37.61µs] INSERT INTO honors (title,id) Values (?,?) [Best Picture 0]
[37.67µs] INSERT INTO honors (id,title) Values (?,?) [1 Best Supporting Actor]
[11.215µs] INSERT INTO honors (id,title) Values (?,?) [2 Best Muffins]
[8.328µs] INSERT INTO honors (id,title) Values (?,?) [3 Second Best Muffins]

As you can see, sometimes it generates (title, id), and sometimes it generates (id, title). This is problematic in my usecase, all statements are prepared (and cached by their SQL string).

The reason this happens is because builder.Insert takes a builder.Eq, which is a golang map, and map iteration order in golang is random (by design).

A possible solution would be to sort the keys, so we get consistent ordering (at a slight performance cost).

Would you be open to this change? I'll happily open a PR once I get your 👍 !

Author: @fasterthanlime These insert statements are generated with go-xorm/builder: ``` [37.61µs] INSERT INTO honors (title,id) Values (?,?) [Best Picture 0] [37.67µs] INSERT INTO honors (id,title) Values (?,?) [1 Best Supporting Actor] [11.215µs] INSERT INTO honors (id,title) Values (?,?) [2 Best Muffins] [8.328µs] INSERT INTO honors (id,title) Values (?,?) [3 Second Best Muffins] ``` As you can see, sometimes it generates `(title, id)`, and sometimes it generates `(id, title)`. This is problematic in my usecase, all statements are prepared (and cached by their SQL string). The reason this happens is because `builder.Insert` takes a `builder.Eq`, which is a golang map, and map iteration order in golang is random (by design). A possible solution would be to sort the keys, so we get consistent ordering (at a slight performance cost). Would you be open to this change? I'll happily open a PR once I get your :+1: !

lunny commented

2018-04-26 00:28:27 +00:00

Author: @lunny

@fasterthanlime please send a PR! Thanks!

Author: @lunny @fasterthanlime please send a PR! Thanks!

Sign in to join this conversation.