xorm/builder
14
18
Fork 16
Code Issues 8 Pull Requests Actions Releases 1 Activity

Add ability to set a dialect on an existing builder #77

Closed
bazanov-a-ju wants to merge 2 commits from master into master
pull from: master
merge into: xorm:master
Conversation 0 Commits 2 Files Changed 2 +39
bazanov-a-ju commented 2020-07-10 22:11:46 +00:00
First-time contributor
Copy Link

Ability to change the dialect of a builder after its creation.

It is helpful when you have to support several dialects simultaneously and you can pass a builder to DB layer and choose the dialect there.

Ability to change the dialect of a builder after its creation. It is helpful when you have to support several dialects simultaneously and you can pass a builder to DB layer and choose the dialect there.
bazanov-a-ju added 1 commit 2020-07-10 22:11:47 +00:00
add ToDialect setter 
ability to change the dialect of a builder after its creation
7f4671b14b
bazanov-a-ju force-pushed master from 613e1baf41 to 7f4671b14b 2020-07-11 20:58:58 +00:00 Compare
lunny reviewed 2020-07-12 02:02:27 +00:00
Dismissed
builder.go
@ -103,2 +103,4 @@
}
// ToDialect sets the dialect
func (b *Builder) ToDialect(dialect string) *Builder {
lunny commented 2020-07-12 02:02:27 +00:00
Owner
Copy Link

Maybe we could have a better name for this function?

Maybe we could have a better name for this function?
bazanov-a-ju commented 2020-07-12 08:32:25 +00:00
Author
First-time contributor
Copy Link

Maybe SetDialect fits better according to "Effective Go" article https://golang.org/doc/effective_go.html#Getters

Or can you suggest better name?

Maybe SetDialect fits better according to "Effective Go" article https://golang.org/doc/effective_go.html#Getters Or can you suggest better name?
lunny commented 2020-10-19 02:43:46 +00:00
Owner
Copy Link

AsDialect(dialect string) maybe better?

`AsDialect(dialect string)` maybe better?
lunny added 1 commit 2021-01-26 09:22:03 +00:00
Merge branch 'master' into master
All checks were successful
continuous-integration/drone/pr Build is passing
Details
ea95afa30c
lunny added the
enhancement
 label 2021-01-26 09:22:10 +00:00
lunny closed this pull request 2024-03-15 14:22:26 +00:00
All checks were successful
continuous-integration/drone/pr Build is passing
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

   
docs

   
duplicate

   
enhancement

   
feature

   
help wanted

   
invalid

   
proposed

   
question

   
security

   
testing

   
wontfix
No Label
bug
docs
duplicate
enhancement
feature
help wanted
invalid
proposed
question
security
testing
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: xorm/builder#77
No description provided.
Delete Branch "master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?