format time when sqlTypeName is core.Varchar #1026

lunny · 2018-06-28T08:14:41Z

DarthPestilane commented

2018-06-28 08:14:41 +00:00

(Migrated from github.com)

I believe that many developers define the created_at or updated_at columns as a string like this:

type User struct {
    Id int64
    // ... other cols
    CreatedAt string `xorm:"'created_at', created"`
}

While using postgres database, a date time string with decimal, like 2018-06-28 15:33:58.942773, will be inserted. But in fact, we don't want a time(string) with decimal.
So I add some codes to format the time value into 2006-01-02 15:04:05:

// ... context
case core.DateTime, core.TimeStamp, core.Varchar: // !DarthPestilane! format time when sqlTypeName is core.Varchar.
    v = t.Format("2006-01-02 15:04:05")
// ... context

Hope can be merged.

I believe that many developers define the `created_at` or `updated_at` columns as a string like this: ```go type User struct { Id int64 // ... other cols CreatedAt string `xorm:"'created_at', created"` } ``` While using `postgres` database, a date time string with decimal, like `2018-06-28 15:33:58.942773`, will be inserted. But in fact, we don't want a time(string) with decimal. So I add some codes to format the time value into `2006-01-02 15:04:05`: ```go // ... context case core.DateTime, core.TimeStamp, core.Varchar: // !DarthPestilane! format time when sqlTypeName is core.Varchar. v = t.Format("2006-01-02 15:04:05") // ... context ``` Hope can be merged.

codecov-io commented

2018-06-28 08:31:43 +00:00

(Migrated from github.com)

Codecov Report

Merging #1026 into master will decrease coverage by 3.1%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master   #1026      +/-   ##
=========================================
- Coverage    57.4%   54.3%   -3.11%     
=========================================
  Files          44      41       -3     
  Lines        7912    7552     -360     
=========================================
- Hits         4542    4101     -441     
- Misses       2806    2934     +128     
+ Partials      564     517      -47

Impacted Files	Coverage Δ
engine.go	`61.51% <100%> (-1.09%)`	⬇️
dialect_mssql.go	`0% <0%> (-73.81%)`	⬇️
session_exist.go	`57.44% <0%> (-5.52%)`	⬇️
rows.go	`50.76% <0%> (-5.38%)`	⬇️
session_update.go	`51.91% <0%> (-4.71%)`	⬇️
helpers.go	`57.41% <0%> (-2.32%)`	⬇️
tag.go	`77.09% <0%> (-2.22%)`	⬇️
session.go	`56.29% <0%> (-2.2%)`	⬇️
session_cols.go	`91.3% <0%> (-2.18%)`	⬇️
xorm.go	`64.61% <0%> (-2.06%)`	⬇️
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ad174c...81d8b70. Read the comment docs.

# [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/1026?src=pr&el=h1) Report > Merging [#1026](https://codecov.io/gh/go-xorm/xorm/pull/1026?src=pr&el=desc) into [master](https://codecov.io/gh/go-xorm/xorm/commit/2ad174c0782132ee46b460793eb306503546ed8d?src=pr&el=desc) will **decrease** coverage by `3.1%`. > The diff coverage is `100%`. [![Impacted file tree graph](https://codecov.io/gh/go-xorm/xorm/pull/1026/graphs/tree.svg?width=650&token=yB5nO1krEe&height=150&src=pr)](https://codecov.io/gh/go-xorm/xorm/pull/1026?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #1026 +/- ## ========================================= - Coverage 57.4% 54.3% -3.11% ========================================= Files 44 41 -3 Lines 7912 7552 -360 ========================================= - Hits 4542 4101 -441 - Misses 2806 2934 +128 + Partials 564 517 -47 ``` | [Impacted Files](https://codecov.io/gh/go-xorm/xorm/pull/1026?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [engine.go](https://codecov.io/gh/go-xorm/xorm/pull/1026/diff?src=pr&el=tree#diff-ZW5naW5lLmdv) | `61.51% <100%> (-1.09%)` | :arrow_down: | | [dialect\_mssql.go](https://codecov.io/gh/go-xorm/xorm/pull/1026/diff?src=pr&el=tree#diff-ZGlhbGVjdF9tc3NxbC5nbw==) | `0% <0%> (-73.81%)` | :arrow_down: | | [session\_exist.go](https://codecov.io/gh/go-xorm/xorm/pull/1026/diff?src=pr&el=tree#diff-c2Vzc2lvbl9leGlzdC5nbw==) | `57.44% <0%> (-5.52%)` | :arrow_down: | | [rows.go](https://codecov.io/gh/go-xorm/xorm/pull/1026/diff?src=pr&el=tree#diff-cm93cy5nbw==) | `50.76% <0%> (-5.38%)` | :arrow_down: | | [session\_update.go](https://codecov.io/gh/go-xorm/xorm/pull/1026/diff?src=pr&el=tree#diff-c2Vzc2lvbl91cGRhdGUuZ28=) | `51.91% <0%> (-4.71%)` | :arrow_down: | | [helpers.go](https://codecov.io/gh/go-xorm/xorm/pull/1026/diff?src=pr&el=tree#diff-aGVscGVycy5nbw==) | `57.41% <0%> (-2.32%)` | :arrow_down: | | [tag.go](https://codecov.io/gh/go-xorm/xorm/pull/1026/diff?src=pr&el=tree#diff-dGFnLmdv) | `77.09% <0%> (-2.22%)` | :arrow_down: | | [session.go](https://codecov.io/gh/go-xorm/xorm/pull/1026/diff?src=pr&el=tree#diff-c2Vzc2lvbi5nbw==) | `56.29% <0%> (-2.2%)` | :arrow_down: | | [session\_cols.go](https://codecov.io/gh/go-xorm/xorm/pull/1026/diff?src=pr&el=tree#diff-c2Vzc2lvbl9jb2xzLmdv) | `91.3% <0%> (-2.18%)` | :arrow_down: | | [xorm.go](https://codecov.io/gh/go-xorm/xorm/pull/1026/diff?src=pr&el=tree#diff-eG9ybS5nbw==) | `64.61% <0%> (-2.06%)` | :arrow_down: | | ... and [24 more](https://codecov.io/gh/go-xorm/xorm/pull/1026/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/go-xorm/xorm/pull/1026?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/go-xorm/xorm/pull/1026?src=pr&el=footer). Last update [2ad174c...81d8b70](https://codecov.io/gh/go-xorm/xorm/pull/1026?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

lunny commented

2018-08-09 03:51:00 +00:00

@DarthPestilane could you add some tests?

lunny modified the milestone from 0.8 to 0.8.2

2019-10-21 03:49:16 +00:00

lunny modified the milestone from 0.8.2 to 1.3.0

2020-01-20 05:40:18 +00:00

lunny referenced this issue from a commit

2020-02-20 08:16:16 +00:00

lunny closed this pull request

2020-02-20 08:16:26 +00:00

lunny modified the milestone from 1.3.0 to 0.8.2